Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: content/public/browser/content_browser_client.cc

Issue 2506183002: Make window.open() IPCs be frame-based (Closed)
Patch Set: Compile fix. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/content_browser_client.cc
diff --git a/content/public/browser/content_browser_client.cc b/content/public/browser/content_browser_client.cc
index 571a89c924c56dcccf5ad219f0b6ec88b70767c9..75317ad0639ec1cd87607a43ba9b5126babb7187 100644
--- a/content/public/browser/content_browser_client.cc
+++ b/content/public/browser/content_browser_client.cc
@@ -284,6 +284,8 @@ ContentBrowserClient::GetPlatformNotificationService() {
}
bool ContentBrowserClient::CanCreateWindow(
+ int opener_render_process_id,
+ int opener_render_frame_id,
const GURL& opener_url,
const GURL& opener_top_level_frame_url,
const GURL& source_origin,
@@ -296,9 +298,6 @@ bool ContentBrowserClient::CanCreateWindow(
bool user_gesture,
bool opener_suppressed,
ResourceContext* context,
- int render_process_id,
- int opener_render_view_id,
- int opener_render_frame_id,
bool* no_javascript_access) {
*no_javascript_access = false;
return true;

Powered by Google App Engine
This is Rietveld 408576698