Make window.open() IPCs be frame-based

content/common/view_messages.h

Index: content/common/view_messages.h
diff --git a/content/common/view_messages.h b/content/common/view_messages.h
index b9d444dbfe04c8058556966598d374301c1dfb1a..95c5c765cee323f58cf9bdb04366523510d4e968 100644
--- a/content/common/view_messages.h
+++ b/content/common/view_messages.h
@@ -495,11 +495,11 @@ IPC_MESSAGE_ROUTED2(ViewMsg_UpdateScreenRects,
                     gfx::Rect /* view_screen_rect */,
                     gfx::Rect /* window_screen_rect */)
 
-// Reply to ViewHostMsg_RequestMove, ViewHostMsg_ShowView, and
-// ViewHostMsg_ShowWidget to inform the renderer that the browser has
-// processed the move.  The browser may have ignored the move, but it finished
-// processing.  This is used because the renderer keeps a temporary cache of
-// the widget position while these asynchronous operations are in progress.
+// Reply to ViewHostMsg_RequestMove, and ViewHostMsg_ShowWidget to inform the

[alexmos, 2016/12/13 18:41:41]

Should we add FrameHostMsg_ShowCreatedWindow to this list, since we still send
the ACK for it?

[ncarter (slow), 2016/12/15 00:33:17]

Done.

+// renderer that the browser has processed the move.  The browser may have
+// ignored the move, but it finished processing.  This is used because the
+// renderer keeps a temporary cache of the widget position while these
+// asynchronous operations are in progress.
 IPC_MESSAGE_ROUTED0(ViewMsg_Move_ACK)
 
 // Used to instruct the RenderView to send back updates to the preferred size.
@@ -626,20 +626,10 @@ IPC_MESSAGE_ROUTED1(ViewMsg_HandleCompositorProto,
 IPC_MESSAGE_ROUTED1(ViewHostMsg_SetNeedsBeginFrames,
                     bool /* enabled */)
 
-// These three messages are sent to the parent RenderViewHost to display the
-// page/widget that was created by
-// CreateWindow/CreateWidget/CreateFullscreenWidget. routing_id
-// refers to the id that was returned from the Create message above.
-// The initial_rect parameter is in screen coordinates.
-//
-// FUTURE: there will probably be flags here to control if the result is
-// in a new window.
-IPC_MESSAGE_ROUTED4(ViewHostMsg_ShowView,
-                    int /* route_id */,
-                    WindowOpenDisposition /* disposition */,
-                    gfx::Rect /* initial_rect */,
-                    bool /* opened_by_user_gesture */)
-
+// These two messages are sent to the parent RenderViewHost to display a widget
+// that was created by CreateWidget/CreateFullscreenWidget. |routing_id| refers

[alexmos, 2016/12/13 18:41:41]

(while you're here) nit: route_id, to match the arg name in /* */ below. 

[ncarter (slow), 2016/12/15 00:33:17]

Done.

+// to the id that was returned from the corresponding Create message above.
+// |initial_rect| is in screen coordinates.
 IPC_MESSAGE_ROUTED2(ViewHostMsg_ShowWidget,
                     int /* route_id */,
                     gfx::Rect /* initial_rect */)