[Interpreter] Collect String feedback on CompareOps.

[Interpreter] Collect String feedback on CompareOps.

Collect string feedback for compare operations. Without this,
functions which have a lot of string compare operations end up with
a high generic type percentage, and don't get optimized until very
late.

Currently TurboFan doesn't use this String feedback for compare
operations, but this could be done in future work if it is useful.

BUG=chromium:660947
Committed: https://crrev.com/5369874042cc01b0aee933071fe21db363f44c5d
Cr-Commit-Position: refs/heads/master@{#41078}

[rmcilroy, 2016-11-16 20:34:03]

rmcilroy@chromium.org changed reviewers:
+ bmeurer@chromium.org, mvstanton@chromium.org

[rmcilroy, 2016-11-16 20:34:04]

The cause of the Promises regression is a natives JS function with string
compare operations not getting optimized due to the runtime profiler thinking it
has generic type information when run in Ignition.

There are two ways we could fix this - either this CL where we don't count the
compare feedback as generic, or we could start tracking string feedback in the
compare bytecode handlers, but given the discussions on
https://bugs.chromium.org/p/v8/issues/detail?id=5400 it seemed like TF doesn't
need this feedback - thoughts TurboFan folks?

[Benedikt Meurer, 2016-11-17 04:36:20]

In this case I'd suggest to start collecting String feedback (and eventually
utilize it in TurboFan). That sounds way better than treating as kAny as
non-generic.

[rmcilroy, 2016-11-17 13:08:37]

Description was changed from

==========
[Interpreter] Don't count CompareOpFeedback::kAny as a generic.

The Interpreter doesn't collect feedback for string compare operations,
so these get marked as kAny. As a result, functions which have a lot of
string compare operations end up with a high generic type percentage, and
don't get optimized until very late. TurboFan doesn't need String feedback
for compare operations, so it should be OK to count these as non-generic.

BUG=chromium:660947
==========

to

==========
[Interpreter] Collect String feedback on CompareOps.

Collect string feedback for compare operations. Without this,
functions which have a lot of string compare operations end up with 
a high generic type percentage, and don't get optimized until very 
late. 

Currently TurboFan doesn't use this String feedback for compare
operations, but this could be done in future work if it is useful.

BUG=chromium:660947
==========

[rmcilroy, 2016-11-17 13:08:43]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 13:08:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rmcilroy, 2016-11-17 13:12:20]

> In this case I'd suggest to start collecting String feedback (and eventually
> utilize it in TurboFan). That sounds way better than treating as kAny as
> non-generic.

Yup that makes sense. Updated CL to collect string feedback. Please take a look.

[commit-bot: I haz the power, 2016-11-17 13:36:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 13:36:01]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2016-11-17 13:45:24]

LGTM once comment addressed.

https://codereview.chromium.org/2506013005/diff/20001/src/globals.h
File src/globals.h (right):

https://codereview.chromium.org/2506013005/diff/20001/src/globals.h#newcode1254
src/globals.h:1254: kAny = 0x7
kAny must be 0xf now

[rmcilroy, 2016-11-17 14:13:14]

https://codereview.chromium.org/2506013005/diff/20001/src/globals.h
File src/globals.h (right):

https://codereview.chromium.org/2506013005/diff/20001/src/globals.h#newcode1254
src/globals.h:1254: kAny = 0x7
On 2016/11/17 13:45:24, Benedikt Meurer wrote:
> kAny must be 0xf now

Done.

[rmcilroy, 2016-11-17 14:13:21]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2016-11-17 14:13:22]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2506013005/#ps40001
(title: "Fix kAny")

[commit-bot: I haz the power, 2016-11-17 14:13:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 14:45:23]

Description was changed from

==========
[Interpreter] Collect String feedback on CompareOps.

Collect string feedback for compare operations. Without this,
functions which have a lot of string compare operations end up with 
a high generic type percentage, and don't get optimized until very 
late. 

Currently TurboFan doesn't use this String feedback for compare
operations, but this could be done in future work if it is useful.

BUG=chromium:660947
==========

to

==========
[Interpreter] Collect String feedback on CompareOps.

Collect string feedback for compare operations. Without this,
functions which have a lot of string compare operations end up with 
a high generic type percentage, and don't get optimized until very 
late. 

Currently TurboFan doesn't use this String feedback for compare
operations, but this could be done in future work if it is useful.

BUG=chromium:660947
==========

[commit-bot: I haz the power, 2016-11-17 14:45:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-17 22:38:22]

Description was changed from

==========
[Interpreter] Collect String feedback on CompareOps.

Collect string feedback for compare operations. Without this,
functions which have a lot of string compare operations end up with 
a high generic type percentage, and don't get optimized until very 
late. 

Currently TurboFan doesn't use this String feedback for compare
operations, but this could be done in future work if it is useful.

BUG=chromium:660947
==========

to

==========
[Interpreter] Collect String feedback on CompareOps.

Collect string feedback for compare operations. Without this,
functions which have a lot of string compare operations end up with
a high generic type percentage, and don't get optimized until very
late.

Currently TurboFan doesn't use this String feedback for compare
operations, but this could be done in future work if it is useful.

BUG=chromium:660947

Committed: https://crrev.com/5369874042cc01b0aee933071fe21db363f44c5d
Cr-Commit-Position: refs/heads/master@{#41078}
==========

[commit-bot: I haz the power, 2016-11-17 22:38:23]

Patchset 3 (id:??) landed as
https://crrev.com/5369874042cc01b0aee933071fe21db363f44c5d
Cr-Commit-Position: refs/heads/master@{#41078}