Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2506283003: [Interpreter] Collect NumberOrOddball feedback in CompareOps. (Closed)

Created:
4 years, 1 month ago by rmcilroy
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Collect NumberOrOddball feedback in CompareOps. Collect feedback for oddballs in the interpreter compare operations handlers. This is important to ensure that we don't consider oddball comparisons as generic, which prevents optimization. BUG=chromium:660947 Committed: https://crrev.com/721e74d9d942fd4f2e3392ea9626d9d404dbbbd0 Cr-Commit-Position: refs/heads/master@{#41081}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -18 lines) Patch
M src/globals.h View 1 2 chunks +5 lines, -4 lines 0 comments Download
M src/interpreter/interpreter.cc View 3 chunks +37 lines, -14 lines 0 comments Download
M src/type-feedback-vector-inl.h View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (12 generated)
rmcilroy
Benedikt, here is one for NumberOrOddball, PTAL, thanks.
4 years, 1 month ago (2016-11-17 13:41:21 UTC) #4
Benedikt Meurer
LGTM.
4 years, 1 month ago (2016-11-17 13:46:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2506283003/20001
4 years, 1 month ago (2016-11-17 15:18:48 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-17 15:21:08 UTC) #15
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/721e74d9d942fd4f2e3392ea9626d9d404dbbbd0 Cr-Commit-Position: refs/heads/master@{#41081}
4 years, 1 month ago (2016-11-17 22:38:31 UTC) #17
rmcilroy
4 years, 1 month ago (2016-11-21 11:45:38 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2517133002/ by rmcilroy@chromium.org.

The reason for reverting is: Turbofan doesn't do proper ToNumber conversions on
NumberOrOddball equality conversions.

BUG=v8:5660.

Powered by Google App Engine
This is Rietveld 408576698