Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: src/compiler/js-typed-lowering.cc

Issue 2506013005: [Interpreter] Collect String feedback on CompareOps. (Closed)
Patch Set: Fix kAny Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/js-operator.cc ('k') | src/compiler/type-hint-analyzer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/js-typed-lowering.h" 5 #include "src/compiler/js-typed-lowering.h"
6 6
7 #include "src/ast/modules.h" 7 #include "src/ast/modules.h"
8 #include "src/builtins/builtins-utils.h" 8 #include "src/builtins/builtins-utils.h"
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/compilation-dependencies.h" 10 #include "src/compilation-dependencies.h"
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 *hint = NumberOperationHint::kSignedSmall; 62 *hint = NumberOperationHint::kSignedSmall;
63 return true; 63 return true;
64 case CompareOperationHint::kNumber: 64 case CompareOperationHint::kNumber:
65 *hint = NumberOperationHint::kNumber; 65 *hint = NumberOperationHint::kNumber;
66 return true; 66 return true;
67 case CompareOperationHint::kNumberOrOddball: 67 case CompareOperationHint::kNumberOrOddball:
68 *hint = NumberOperationHint::kNumberOrOddball; 68 *hint = NumberOperationHint::kNumberOrOddball;
69 return true; 69 return true;
70 case CompareOperationHint::kAny: 70 case CompareOperationHint::kAny:
71 case CompareOperationHint::kNone: 71 case CompareOperationHint::kNone:
72 case CompareOperationHint::kString:
72 break; 73 break;
73 } 74 }
74 } 75 }
75 return false; 76 return false;
76 } 77 }
77 78
78 // Check if a string addition will definitely result in creating a ConsString, 79 // Check if a string addition will definitely result in creating a ConsString,
79 // i.e. if the combined length of the resulting string exceeds the ConsString 80 // i.e. if the combined length of the resulting string exceeds the ConsString
80 // minimum length. 81 // minimum length.
81 bool ShouldCreateConsString() { 82 bool ShouldCreateConsString() {
(...skipping 2192 matching lines...) Expand 10 before | Expand all | Expand 10 after
2274 } 2275 }
2275 2276
2276 2277
2277 CompilationDependencies* JSTypedLowering::dependencies() const { 2278 CompilationDependencies* JSTypedLowering::dependencies() const {
2278 return dependencies_; 2279 return dependencies_;
2279 } 2280 }
2280 2281
2281 } // namespace compiler 2282 } // namespace compiler
2282 } // namespace internal 2283 } // namespace internal
2283 } // namespace v8 2284 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/js-operator.cc ('k') | src/compiler/type-hint-analyzer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698