Move FS related mojo methods to ArcFileSystemInstance.

Move FS related mojo methods to ArcFileSystemInstance.

Existing methods are suffixed with "Deprecated". Note that
new methods will be soon implemented in Android side but
they are not available at this moment.

BUG=chromium:666231
TEST=unit_tests --gtest_filter='ArcContentFileSystem*'

Committed: https://crrev.com/9b3835940eb71e1e9b3bfe2a7f60f381bcf63238
Cr-Commit-Position: refs/heads/master@{#434603}

[Shuhei Takahashi, 2016-11-18 07:25:32]

The CQ bit was checked by nya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 07:25:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Shuhei Takahashi, 2016-11-18 07:49:37]

nya@chromium.org changed reviewers:
+ hashimoto@chromium.org, rickyz@chromium.org, yusukes@chromium.org

[Shuhei Takahashi, 2016-11-18 07:49:38]

rickyz: PTAL

yusukes, hashimoto: FYI

[commit-bot: I haz the power, 2016-11-18 09:52:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 09:52:02]

Dry run: This issue passed the CQ dry run.

[Luis Héctor Chávez, 2016-11-18 16:37:53]

lhchavez@chromium.org changed reviewers:
+ lhchavez@chromium.org

[Luis Héctor Chávez, 2016-11-18 16:37:53]

drive-by

https://codereview.chromium.org/2505993005/diff/1/components/arc/common/inten...
File components/arc/common/intent_helper.mojom (right):

https://codereview.chromium.org/2505993005/diff/1/components/arc/common/inten...
components/arc/common/intent_helper.mojom:120: [MinVersion=15]
GetFileSize@11(string url) => (int64 size);
Can you add the Deprecated suffix to this method please?

[Yusuke Sato, 2016-11-18 19:09:38]

lgtm with nits:

https://codereview.chromium.org/2505993005/diff/1/components/arc/common/file_...
File components/arc/common/file_system.mojom (right):

https://codereview.chromium.org/2505993005/diff/1/components/arc/common/file_...
components/arc/common/file_system.mojom:14: RequestMediaScan@0(array<string>
paths);
move to L23 to sort methods by name?

https://codereview.chromium.org/2505993005/diff/1/components/arc/common/inten...
File components/arc/common/intent_helper.mojom (right):

https://codereview.chromium.org/2505993005/diff/1/components/arc/common/inten...
components/arc/common/intent_helper.mojom:138: [MinVersion=15]
OpenFileToRead@12(string url) => (handle? fd);
same, OpenFileToReadDeprecated

[rickyz (no longer on Chrome), 2016-11-18 22:53:32]

lgtm

[Shuhei Takahashi, 2016-11-21 05:00:34]

Description was changed from

==========
Move FS related mojo methods to ArcFileSystemInstance.

BUG=chromium:666231
TEST=trybots
==========

to

==========
Move FS related mojo methods to ArcFileSystemInstance.

Existing methods are suffixed with "Deprecated". Note that new methods will be
soon implemented in Android side but they are not available at this moment.

BUG=chromium:666231
TEST=unit_tests
TEST=trybots
==========

[Shuhei Takahashi, 2016-11-21 05:06:51]

Description was changed from

==========
Move FS related mojo methods to ArcFileSystemInstance.

Existing methods are suffixed with "Deprecated". Note that new methods will be
soon implemented in Android side but they are not available at this moment.

BUG=chromium:666231
TEST=unit_tests
TEST=trybots
==========

to

==========
Move FS related mojo methods to ArcFileSystemInstance.

Existing methods are suffixed with "Deprecated". Note that new methods will be
soon implemented in Android side but they are not available at this moment.

BUG=chromium:666231
TEST=unit_tests --gtest_filter='ArcContentFileSystem*'
TEST=trybots
==========

[Shuhei Takahashi, 2016-11-21 05:10:40]

Description was changed from

==========
Move FS related mojo methods to ArcFileSystemInstance.

Existing methods are suffixed with "Deprecated". Note that new methods will be
soon implemented in Android side but they are not available at this moment.

BUG=chromium:666231
TEST=unit_tests --gtest_filter='ArcContentFileSystem*'
TEST=trybots
==========

to

==========
Move FS related mojo methods to ArcFileSystemInstance.

Existing methods are suffixed with "Deprecated". Note that new methods will be
soon implemented in Android side but they are not available at this moment.

BUG=chromium:666231
TEST=unit_tests --gtest_filter='ArcContentFileSystem*'
==========

[Shuhei Takahashi, 2016-11-21 06:26:49]

The CQ bit was checked by nya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 06:26:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Shuhei Takahashi, 2016-11-21 06:38:02]

Description was changed from

==========
Move FS related mojo methods to ArcFileSystemInstance.

Existing methods are suffixed with "Deprecated". Note that new methods will be
soon implemented in Android side but they are not available at this moment.

BUG=chromium:666231
TEST=unit_tests --gtest_filter='ArcContentFileSystem*'
==========

to

==========
Move FS related mojo methods to ArcFileSystemInstance.

Existing methods are suffixed with "Deprecated". Note that
new methods will be soon implemented in Android side but
they are not available at this moment.

BUG=chromium:666231
TEST=unit_tests --gtest_filter='ArcContentFileSystem*'
==========

[Shuhei Takahashi, 2016-11-21 06:44:49]

The CQ bit was checked by nya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 06:45:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 08:59:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 08:59:49]

Dry run: This issue passed the CQ dry run.

[Shuhei Takahashi, 2016-11-21 11:06:29]

PTAL

https://codereview.chromium.org/2505993005/diff/1/components/arc/common/file_...
File components/arc/common/file_system.mojom (right):

https://codereview.chromium.org/2505993005/diff/1/components/arc/common/file_...
components/arc/common/file_system.mojom:14: RequestMediaScan@0(array<string>
paths);
On 2016/11/18 19:09:38, Yusuke Sato wrote:
> move to L23 to sort methods by name?

Done.

https://codereview.chromium.org/2505993005/diff/1/components/arc/common/inten...
File components/arc/common/intent_helper.mojom (right):

https://codereview.chromium.org/2505993005/diff/1/components/arc/common/inten...
components/arc/common/intent_helper.mojom:120: [MinVersion=15]
GetFileSize@11(string url) => (int64 size);
On 2016/11/18 16:37:53, Luis Héctor Chávez wrote:
> Can you add the Deprecated suffix to this method please?

Sure, done.

https://codereview.chromium.org/2505993005/diff/1/components/arc/common/inten...
components/arc/common/intent_helper.mojom:138: [MinVersion=15]
OpenFileToRead@12(string url) => (handle? fd);
On 2016/11/18 19:09:38, Yusuke Sato wrote:
> same, OpenFileToReadDeprecated

Done.

[Yusuke Sato, 2016-11-21 16:52:30]

lgtm

https://codereview.chromium.org/2505993005/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/fileapi/intent_helper_util.cc (right):

https://codereview.chromium.org/2505993005/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/fileapi/intent_helper_util.cc:33:
"GetFileSizeDeprecated", 15);
nit: not your fault, but can you name the constant? I think we usually use
constexpr int32 kXXX for this.

https://codereview.chromium.org/2505993005/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/fileapi/intent_helper_util.cc:61:
"OpenFileToReadDeprecated", 15);
same

[Yusuke Sato, 2016-11-21 17:49:01]

https://codereview.chromium.org/2505993005/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/fileapi/intent_helper_util.cc (right):

https://codereview.chromium.org/2505993005/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/fileapi/intent_helper_util.cc:33:
"GetFileSizeDeprecated", 15);
On 2016/11/21 16:52:30, Yusuke Sato wrote:
> nit: not your fault, but can you name the constant? I think we usually use
> constexpr int32 kXXX for this.

sorry, typo. I meant 'constexpr uint32_t kXXX'.

[Shuhei Takahashi, 2016-11-22 08:55:42]

Thanks for reviewing!

Since it's soon after the branch cut, I'll submit this change early next week.

https://codereview.chromium.org/2505993005/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/fileapi/intent_helper_util.cc (right):

https://codereview.chromium.org/2505993005/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/fileapi/intent_helper_util.cc:33:
"GetFileSizeDeprecated", 15);
On 2016/11/21 17:49:01, Yusuke Sato wrote:
> On 2016/11/21 16:52:30, Yusuke Sato wrote:
> > nit: not your fault, but can you name the constant? I think we usually use
> > constexpr int32 kXXX for this.
> 
> sorry, typo. I meant 'constexpr uint32_t kXXX'.

Done.

https://codereview.chromium.org/2505993005/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/fileapi/intent_helper_util.cc:61:
"OpenFileToReadDeprecated", 15);
On 2016/11/21 16:52:30, Yusuke Sato wrote:
> same

Done.

[Luis Héctor Chávez, 2016-11-22 18:54:01]

lgtm

[Shuhei Takahashi, 2016-11-28 04:08:47]

The CQ bit was checked by nya@chromium.org

[Shuhei Takahashi, 2016-11-28 04:08:47]

The patchset sent to the CQ was uploaded after l-g-t-m from rickyz@chromium.org,
yusukes@chromium.org
Link to the patchset: https://codereview.chromium.org/2505993005/#ps80001
(title: "Define version constants.")

[commit-bot: I haz the power, 2016-11-28 04:08:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 04:36:20]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480306127248100,
"parent_rev": "2647e9a0441571becb3a2147ffa6f872334a2a96", "commit_rev":
"e6b536518bfaf30f939bead38eb5005b02555277"}

[commit-bot: I haz the power, 2016-11-28 04:36:48]

Description was changed from

==========
Move FS related mojo methods to ArcFileSystemInstance.

Existing methods are suffixed with "Deprecated". Note that
new methods will be soon implemented in Android side but
they are not available at this moment.

BUG=chromium:666231
TEST=unit_tests --gtest_filter='ArcContentFileSystem*'
==========

to

==========
Move FS related mojo methods to ArcFileSystemInstance.

Existing methods are suffixed with "Deprecated". Note that
new methods will be soon implemented in Android side but
they are not available at this moment.

BUG=chromium:666231
TEST=unit_tests --gtest_filter='ArcContentFileSystem*'
==========

[commit-bot: I haz the power, 2016-11-28 04:36:49]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-28 04:39:20]

Description was changed from

==========
Move FS related mojo methods to ArcFileSystemInstance.

Existing methods are suffixed with "Deprecated". Note that
new methods will be soon implemented in Android side but
they are not available at this moment.

BUG=chromium:666231
TEST=unit_tests --gtest_filter='ArcContentFileSystem*'
==========

to

==========
Move FS related mojo methods to ArcFileSystemInstance.

Existing methods are suffixed with "Deprecated". Note that
new methods will be soon implemented in Android side but
they are not available at this moment.

BUG=chromium:666231
TEST=unit_tests --gtest_filter='ArcContentFileSystem*'

Committed: https://crrev.com/9b3835940eb71e1e9b3bfe2a7f60f381bcf63238
Cr-Commit-Position: refs/heads/master@{#434603}
==========

[commit-bot: I haz the power, 2016-11-28 04:39:21]

Patchset 5 (id:??) landed as
https://crrev.com/9b3835940eb71e1e9b3bfe2a7f60f381bcf63238
Cr-Commit-Position: refs/heads/master@{#434603}