Use ArcFileSystemInstance to access files on ARC.

Use ArcFileSystemInstance to access files on ARC.

No functionality should change.

BUG=chromium:666231
TEST=unit_tests --gtest_filter='ArcContentFileSystem*'
TEST=Open a PDF file from Android storage viewer.

Committed: https://crrev.com/3cf19023ea53f77727741812143b7306bfed94be
Cr-Commit-Position: refs/heads/master@{#435161}

[Shuhei Takahashi, 2016-11-18 07:26:02]

The CQ bit was checked by nya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 07:26:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Shuhei Takahashi, 2016-11-18 07:49:40]

nya@chromium.org changed reviewers:
+ hashimoto@chromium.org, yusukes@chromium.org

[Shuhei Takahashi, 2016-11-18 07:49:41]

yusukes: PTAL

hashimoto: FYI

[commit-bot: I haz the power, 2016-11-18 07:52:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 07:52:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Shuhei Takahashi, 2016-11-18 07:57:32]

On 2016/11/18 07:49:41, Shuhei Takahashi wrote:
> yusukes: PTAL
> 
> hashimoto: FYI

Oops, I failed to run unit tests... I'm fixing now.

[hashimoto, 2016-11-18 08:00:13]

https://codereview.chromium.org/2511973003/diff/1/chrome/browser/chromeos/BUI...
File chrome/browser/chromeos/BUILD.gn (right):

https://codereview.chromium.org/2511973003/diff/1/chrome/browser/chromeos/BUI...
chrome/browser/chromeos/BUILD.gn:233: "arc/fileapi/arc_file_system_util.cc",
suggestion: "file system util" sounds a bit ambiguous (anything under
arc/fileapi should be related to file systems after all). How about something
more specific? (e.g. arc_file_system_instance_util.cc)

[Shuhei Takahashi, 2016-11-18 08:40:39]

Description was changed from

==========
Use ArcFileSystemInstance to access files on ARC.

No functionality should change.

BUG=chromium:666231
TEST=Open a PDF file from Android storage viewer.
==========

to

==========
Use ArcFileSystemInstance to access files on ARC.

No functionality should change.

BUG=chromium:666231
TEST=unit_tests --gtest_filter='ArcContentFileSystemFileStreamReaderTest.*'
TEST=Open a PDF file from Android storage viewer.
==========

[Shuhei Takahashi, 2016-11-18 08:41:04]

https://codereview.chromium.org/2511973003/diff/1/chrome/browser/chromeos/BUI...
File chrome/browser/chromeos/BUILD.gn (right):

https://codereview.chromium.org/2511973003/diff/1/chrome/browser/chromeos/BUI...
chrome/browser/chromeos/BUILD.gn:233: "arc/fileapi/arc_file_system_util.cc",
On 2016/11/18 08:00:12, hashimoto wrote:
> suggestion: "file system util" sounds a bit ambiguous (anything under
> arc/fileapi should be related to file systems after all). How about something
> more specific? (e.g. arc_file_system_instance_util.cc)

Sounds good, done.

[Shuhei Takahashi, 2016-11-18 09:52:31]

The CQ bit was checked by nya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 09:52:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 12:17:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 12:17:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Yusuke Sato, 2016-11-18 19:21:05]

linux_chromium_chromeos_ozone_rel_ng's failure might be yours, please check.
mostly style comments below:

https://codereview.chromium.org/2511973003/diff/20001/chrome/browser/chromeos...
File
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader_unittest.cc
(left):

https://codereview.chromium.org/2511973003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader_unittest.cc:32:
void GetFileSize(const mojo::String& url,
oops, please rebase on top of
https://chromium.googlesource.com/chromium/src/+/e6db796a2f93afe3913d9c84c176...
.

https://codereview.chromium.org/2511973003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/fileapi/arc_file_system_instance_util.h
(right):

https://codereview.chromium.org/2511973003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/fileapi/arc_file_system_instance_util.h:9: #include
"url/gurl.h"
nit: class GURL;

https://codereview.chromium.org/2511973003/diff/20001/components/arc/test/fak...
File components/arc/test/fake_file_system_instance.cc (right):

https://codereview.chromium.org/2511973003/diff/20001/components/arc/test/fak...
components/arc/test/fake_file_system_instance.cc:9:
FakeFileSystemInstance::FakeFileSystemInstance() {}
nit: = default;

?

https://codereview.chromium.org/2511973003/diff/20001/components/arc/test/fak...
components/arc/test/fake_file_system_instance.cc:11:
FakeFileSystemInstance::~FakeFileSystemInstance() {}
same

https://codereview.chromium.org/2511973003/diff/20001/components/arc/test/fak...
File components/arc/test/fake_file_system_instance.h (right):

https://codereview.chromium.org/2511973003/diff/20001/components/arc/test/fak...
components/arc/test/fake_file_system_instance.h:12: #include
"mojo/public/cpp/bindings/binding.h"
nit: is this necessary?

https://codereview.chromium.org/2511973003/diff/20001/components/arc/test/fak...
components/arc/test/fake_file_system_instance.h:32:
DISALLOW_COPY_AND_ASSIGN(FakeFileSystemInstance);
nit: include base/macros.h

[Shuhei Takahashi, 2016-11-21 05:10:49]

Description was changed from

==========
Use ArcFileSystemInstance to access files on ARC.

No functionality should change.

BUG=chromium:666231
TEST=unit_tests --gtest_filter='ArcContentFileSystemFileStreamReaderTest.*'
TEST=Open a PDF file from Android storage viewer.
==========

to

==========
Use ArcFileSystemInstance to access files on ARC.

No functionality should change.

BUG=chromium:666231
TEST=unit_tests --gtest_filter='ArcContentFileSystem*'
TEST=Open a PDF file from Android storage viewer.
==========

[Shuhei Takahashi, 2016-11-21 06:44:23]

The CQ bit was checked by nya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 06:44:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 09:20:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 09:20:27]

Dry run: This issue passed the CQ dry run.

[Shuhei Takahashi, 2016-11-21 11:06:43]

PTAL

https://codereview.chromium.org/2511973003/diff/20001/chrome/browser/chromeos...
File
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader_unittest.cc
(left):

https://codereview.chromium.org/2511973003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader_unittest.cc:32:
void GetFileSize(const mojo::String& url,
On 2016/11/18 19:21:05, Yusuke Sato wrote:
> oops, please rebase on top of
>
https://chromium.googlesource.com/chromium/src/+/e6db796a2f93afe3913d9c84c176...
> .

Done.

https://codereview.chromium.org/2511973003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/fileapi/arc_file_system_instance_util.h
(right):

https://codereview.chromium.org/2511973003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/fileapi/arc_file_system_instance_util.h:9: #include
"url/gurl.h"
On 2016/11/18 19:21:05, Yusuke Sato wrote:
> nit: class GURL;

Done.

https://codereview.chromium.org/2511973003/diff/20001/components/arc/test/fak...
File components/arc/test/fake_file_system_instance.cc (right):

https://codereview.chromium.org/2511973003/diff/20001/components/arc/test/fak...
components/arc/test/fake_file_system_instance.cc:9:
FakeFileSystemInstance::FakeFileSystemInstance() {}
On 2016/11/18 19:21:05, Yusuke Sato wrote:
> nit: = default;
> 
> ?

Done.

https://codereview.chromium.org/2511973003/diff/20001/components/arc/test/fak...
components/arc/test/fake_file_system_instance.cc:11:
FakeFileSystemInstance::~FakeFileSystemInstance() {}
On 2016/11/18 19:21:05, Yusuke Sato wrote:
> same

Done.

https://codereview.chromium.org/2511973003/diff/20001/components/arc/test/fak...
File components/arc/test/fake_file_system_instance.h (right):

https://codereview.chromium.org/2511973003/diff/20001/components/arc/test/fak...
components/arc/test/fake_file_system_instance.h:12: #include
"mojo/public/cpp/bindings/binding.h"
On 2016/11/18 19:21:05, Yusuke Sato wrote:
> nit: is this necessary?

Not necessary, thanks.

https://codereview.chromium.org/2511973003/diff/20001/components/arc/test/fak...
components/arc/test/fake_file_system_instance.h:32:
DISALLOW_COPY_AND_ASSIGN(FakeFileSystemInstance);
On 2016/11/18 19:21:05, Yusuke Sato wrote:
> nit: include base/macros.h

Done.

[Yusuke Sato, 2016-11-21 16:47:45]

lgtm

[hashimoto, 2016-11-22 09:03:49]

lgtm

[Shuhei Takahashi, 2016-11-30 06:14:26]

Verified again with Chrome OS ToT. Submitting...

[Shuhei Takahashi, 2016-11-30 06:14:34]

The CQ bit was checked by nya@chromium.org

[Shuhei Takahashi, 2016-11-30 06:14:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
yusukes@chromium.org, hashimoto@chromium.org
Link to the patchset: https://codereview.chromium.org/2511973003/#ps80001
(title: "Rebased to ToT.")

[commit-bot: I haz the power, 2016-11-30 06:15:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 08:20:05]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480486474706460,
"parent_rev": "29ffaddbfad1cfbd09c29abb157f6b3dccd3a70b", "commit_rev":
"c15ceaa500be23079f76e2fee9fa095075c0b563"}

[commit-bot: I haz the power, 2016-11-30 08:20:36]

Description was changed from

==========
Use ArcFileSystemInstance to access files on ARC.

No functionality should change.

BUG=chromium:666231
TEST=unit_tests --gtest_filter='ArcContentFileSystem*'
TEST=Open a PDF file from Android storage viewer.
==========

to

==========
Use ArcFileSystemInstance to access files on ARC.

No functionality should change.

BUG=chromium:666231
TEST=unit_tests --gtest_filter='ArcContentFileSystem*'
TEST=Open a PDF file from Android storage viewer.
==========

[commit-bot: I haz the power, 2016-11-30 08:20:37]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-30 08:23:00]

Description was changed from

==========
Use ArcFileSystemInstance to access files on ARC.

No functionality should change.

BUG=chromium:666231
TEST=unit_tests --gtest_filter='ArcContentFileSystem*'
TEST=Open a PDF file from Android storage viewer.
==========

to

==========
Use ArcFileSystemInstance to access files on ARC.

No functionality should change.

BUG=chromium:666231
TEST=unit_tests --gtest_filter='ArcContentFileSystem*'
TEST=Open a PDF file from Android storage viewer.

Committed: https://crrev.com/3cf19023ea53f77727741812143b7306bfed94be
Cr-Commit-Position: refs/heads/master@{#435161}
==========

[commit-bot: I haz the power, 2016-11-30 08:23:02]

Patchset 5 (id:??) landed as
https://crrev.com/3cf19023ea53f77727741812143b7306bfed94be
Cr-Commit-Position: refs/heads/master@{#435161}