Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Unified Diff: chrome/browser/chromeos/arc/fileapi/intent_helper_util.cc

Issue 2505993005: Move FS related mojo methods to ArcFileSystemInstance. (Closed)
Patch Set: Define version constants. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/arc/fileapi/intent_helper_util.h ('k') | components/arc/common/file_system.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/arc/fileapi/intent_helper_util.cc
diff --git a/chrome/browser/chromeos/arc/fileapi/intent_helper_util.cc b/chrome/browser/chromeos/arc/fileapi/intent_helper_util.cc
index 4b66f75bc38f5641bf45f1efed5fbc781a13e407..f69eaac816199633723aa9f9e2fa66ecbeebe229 100644
--- a/chrome/browser/chromeos/arc/fileapi/intent_helper_util.cc
+++ b/chrome/browser/chromeos/arc/fileapi/intent_helper_util.cc
@@ -13,17 +13,17 @@ namespace intent_helper_util {
namespace {
-void OnGetFileSize(
- const mojom::IntentHelperInstance::GetFileSizeCallback& callback,
- int64_t size) {
+constexpr uint32_t kGetFileSizeVersion = 15;
+constexpr uint32_t kOpenFileToReadVersion = 15;
+
+void OnGetFileSize(const GetFileSizeCallback& callback, int64_t size) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
content::BrowserThread::PostTask(content::BrowserThread::IO, FROM_HERE,
base::Bind(callback, size));
}
-void GetFileSizeOnUIThread(
- const GURL& arc_url,
- const mojom::IntentHelperInstance::GetFileSizeCallback& callback) {
+void GetFileSizeOnUIThread(const GURL& arc_url,
+ const GetFileSizeCallback& callback) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
auto* arc_bridge_service = arc::ArcBridgeService::Get();
if (!arc_bridge_service) {
@@ -32,28 +32,26 @@ void GetFileSizeOnUIThread(
return;
}
mojom::IntentHelperInstance* intent_helper_instance =
- arc_bridge_service->intent_helper()->GetInstanceForMethod("GetFileSize",
- 15);
+ arc_bridge_service->intent_helper()->GetInstanceForMethod(
+ "GetFileSizeDeprecated", kGetFileSizeVersion);
if (!intent_helper_instance) {
LOG(ERROR) << "Failed to get IntentHelperInstance.";
OnGetFileSize(callback, -1);
return;
}
- intent_helper_instance->GetFileSize(arc_url.spec(),
- base::Bind(&OnGetFileSize, callback));
+ intent_helper_instance->GetFileSizeDeprecated(
+ arc_url.spec(), base::Bind(&OnGetFileSize, callback));
}
-void OnOpenFileToRead(
- const mojom::IntentHelperInstance::OpenFileToReadCallback& callback,
- mojo::ScopedHandle handle) {
+void OnOpenFileToRead(const OpenFileToReadCallback& callback,
+ mojo::ScopedHandle handle) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
content::BrowserThread::PostTask(content::BrowserThread::IO, FROM_HERE,
base::Bind(callback, base::Passed(&handle)));
}
-void OpenFileToReadOnUIThread(
- const GURL& arc_url,
- const mojom::IntentHelperInstance::OpenFileToReadCallback& callback) {
+void OpenFileToReadOnUIThread(const GURL& arc_url,
+ const OpenFileToReadCallback& callback) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
auto* arc_bridge_service = arc::ArcBridgeService::Get();
if (!arc_bridge_service) {
@@ -63,30 +61,28 @@ void OpenFileToReadOnUIThread(
}
mojom::IntentHelperInstance* intent_helper_instance =
arc_bridge_service->intent_helper()->GetInstanceForMethod(
- "OpenFileToRead", 15);
+ "OpenFileToReadDeprecated", kOpenFileToReadVersion);
if (!intent_helper_instance) {
LOG(ERROR) << "Failed to get IntentHelperInstance.";
OnOpenFileToRead(callback, mojo::ScopedHandle());
return;
}
- intent_helper_instance->OpenFileToRead(
+ intent_helper_instance->OpenFileToReadDeprecated(
arc_url.spec(), base::Bind(&OnOpenFileToRead, callback));
}
} // namespace
-void GetFileSizeOnIOThread(
- const GURL& arc_url,
- const mojom::IntentHelperInstance::GetFileSizeCallback& callback) {
+void GetFileSizeOnIOThread(const GURL& arc_url,
+ const GetFileSizeCallback& callback) {
DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
content::BrowserThread::PostTask(
content::BrowserThread::UI, FROM_HERE,
base::Bind(&GetFileSizeOnUIThread, arc_url, callback));
}
-void OpenFileToReadOnIOThread(
- const GURL& arc_url,
- const mojom::IntentHelperInstance::OpenFileToReadCallback& callback) {
+void OpenFileToReadOnIOThread(const GURL& arc_url,
+ const OpenFileToReadCallback& callback) {
DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
content::BrowserThread::PostTask(
content::BrowserThread::UI, FROM_HERE,
« no previous file with comments | « chrome/browser/chromeos/arc/fileapi/intent_helper_util.h ('k') | components/arc/common/file_system.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698