Let lowestFloatLogicalBottom() take EClear instead of FloatingObject::Type

Let lowestFloatLogicalBottom() take EClear instead of FloatingObject::Type

Committed: https://crrev.com/faa6978b0497ade609219dfa7f7b74d212602e90
Cr-Commit-Position: refs/heads/master@{#432801}

[mstensho (USE GERRIT), 2016-11-16 22:27:17]

The CQ bit was checked by mstensho@opera.com to run a CQ dry run

[mstensho (USE GERRIT), 2016-11-16 22:27:59]

mstensho@opera.com changed reviewers:
+ szager@chromium.org

[commit-bot: I haz the power, 2016-11-16 22:28:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[szager1, 2016-11-16 22:35:35]

Nice cleanup!

https://codereview.chromium.org/2505853004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBlockFlow.h (right):

https://codereview.chromium.org/2505853004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBlockFlow.h:379: LayoutUnit
lowestFloatLogicalBottom(
You should be able to eliminate this method by providing a default for the new
version:

LayoutUnit lowestFloatLogicalBottom(EClear = ClearBoth) const;

[mstensho (USE GERRIT), 2016-11-16 22:44:24]

The CQ bit was checked by mstensho@opera.com to run a CQ dry run

[mstensho (USE GERRIT), 2016-11-16 22:45:04]

Description was changed from

==========
Add lowestFloatLogicalBottom() overload that takes EClear.
==========

to

==========
Let lowestFloatLogicalBottom() take EClear instead of FloatingObject::Type
==========

[commit-bot: I haz the power, 2016-11-16 22:45:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mstensho (USE GERRIT), 2016-11-16 22:45:37]

Also updated the commit message, since we're no longer adding an override. :)

https://codereview.chromium.org/2505853004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBlockFlow.h (right):

https://codereview.chromium.org/2505853004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBlockFlow.h:379: LayoutUnit
lowestFloatLogicalBottom(
On 2016/11/16 22:35:35, szager1 wrote:
> You should be able to eliminate this method by providing a default for the new
> version:
> 
> LayoutUnit lowestFloatLogicalBottom(EClear = ClearBoth) const;

Indeed! Looks like I didn't bother to check if there were still callers that
passed FloatingObject::Type. Thanks!

Done.

[szager1, 2016-11-16 22:50:50]

lgtm

[mstensho (USE GERRIT), 2016-11-16 22:52:38]

The CQ bit was unchecked by mstensho@opera.com

[mstensho (USE GERRIT), 2016-11-16 22:52:44]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2016-11-16 22:53:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 23:44:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 23:44:13]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mstensho (USE GERRIT), 2016-11-17 06:15:14]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2016-11-17 06:15:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 07:34:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 07:38:41]

Description was changed from

==========
Let lowestFloatLogicalBottom() take EClear instead of FloatingObject::Type
==========

to

==========
Let lowestFloatLogicalBottom() take EClear instead of FloatingObject::Type

Committed: https://crrev.com/faa6978b0497ade609219dfa7f7b74d212602e90
Cr-Commit-Position: refs/heads/master@{#432801}
==========

[commit-bot: I haz the power, 2016-11-17 07:38:42]

Patchset 2 (id:??) landed as
https://crrev.com/faa6978b0497ade609219dfa7f7b74d212602e90
Cr-Commit-Position: refs/heads/master@{#432801}