Let lowestFloatLogicalBottom() take EClear instead of FloatingObject::Type

third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2007 David Smith (catfish.man@gmail.com)
  * Copyright (C) 2003-2013 Apple Inc. All rights reserved.
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
@@ skipping 358 matching lines @@
     return containsFloats() ? m_floatingObjects->set().last().get() : nullptr;
   }
 
   void setShouldDoFullPaintInvalidationForFirstLine();
 
   void simplifiedNormalFlowInlineLayout();
   bool recalcInlineChildrenOverflowAfterStyleChange();
 
   PositionWithAffinity positionForPoint(const LayoutPoint&) override;
 
   LayoutUnit lowestFloatLogicalBottom(

[szager1, 2016/11/16 22:35:35]

You should be able to eliminate this method by providing a default for the new
version:

LayoutUnit lowestFloatLogicalBottom(EClear = ClearBoth) const;

[mstensho (USE GERRIT), 2016/11/16 22:45:37]

Indeed! Looks like I didn't bother to check if there were still callers that
passed FloatingObject::Type. Thanks!

Done.

       FloatingObject::Type = FloatingObject::FloatLeftRight) const;
 
+  LayoutUnit lowestFloatLogicalBottom(EClear) const;
+
   bool hasOverhangingFloats() const {
     return parent() && containsFloats() &&
            lowestFloatLogicalBottom() > logicalHeight();
   }
   bool isOverhangingFloat(const FloatingObject& floatObject) const {
     return logicalBottomForFloat(floatObject) > logicalHeight();
   }
 
   LayoutUnit logicalHeightWithVisibleOverflow() const final;
 
@@ skipping 538 matching lines @@
   void positionDialog();
 
   // END METHODS DEFINED IN LayoutBlockFlowLine
 };
 
 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBlockFlow, isLayoutBlockFlow());
 
 }  // namespace blink
 
 #endif  // LayoutBlockFlow_h