Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

Issue 2505853004: Let lowestFloatLogicalBottom() take EClear instead of FloatingObject::Type (Closed)
Patch Set: Code review. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003-2013 Apple Inc. All rights reserved. 5 * Copyright (C) 2003-2013 Apple Inc. All rights reserved.
6 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
7 * Copyright (C) 2013 Google Inc. All rights reserved. 7 * Copyright (C) 2013 Google Inc. All rights reserved.
8 * 8 *
9 * Redistribution and use in source and binary forms, with or without 9 * Redistribution and use in source and binary forms, with or without
10 * modification, are permitted provided that the following conditions are 10 * modification, are permitted provided that the following conditions are
(...skipping 358 matching lines...) Expand 10 before | Expand all | Expand 10 after
369 return containsFloats() ? m_floatingObjects->set().last().get() : nullptr; 369 return containsFloats() ? m_floatingObjects->set().last().get() : nullptr;
370 } 370 }
371 371
372 void setShouldDoFullPaintInvalidationForFirstLine(); 372 void setShouldDoFullPaintInvalidationForFirstLine();
373 373
374 void simplifiedNormalFlowInlineLayout(); 374 void simplifiedNormalFlowInlineLayout();
375 bool recalcInlineChildrenOverflowAfterStyleChange(); 375 bool recalcInlineChildrenOverflowAfterStyleChange();
376 376
377 PositionWithAffinity positionForPoint(const LayoutPoint&) override; 377 PositionWithAffinity positionForPoint(const LayoutPoint&) override;
378 378
379 LayoutUnit lowestFloatLogicalBottom( 379 LayoutUnit lowestFloatLogicalBottom(EClear = ClearBoth) const;
380 FloatingObject::Type = FloatingObject::FloatLeftRight) const;
381 380
382 bool hasOverhangingFloats() const { 381 bool hasOverhangingFloats() const {
383 return parent() && containsFloats() && 382 return parent() && containsFloats() &&
384 lowestFloatLogicalBottom() > logicalHeight(); 383 lowestFloatLogicalBottom() > logicalHeight();
385 } 384 }
386 bool isOverhangingFloat(const FloatingObject& floatObject) const { 385 bool isOverhangingFloat(const FloatingObject& floatObject) const {
387 return logicalBottomForFloat(floatObject) > logicalHeight(); 386 return logicalBottomForFloat(floatObject) > logicalHeight();
388 } 387 }
389 388
390 LayoutUnit logicalHeightWithVisibleOverflow() const final; 389 LayoutUnit logicalHeightWithVisibleOverflow() const final;
(...skipping 539 matching lines...) Expand 10 before | Expand all | Expand 10 after
930 void positionDialog(); 929 void positionDialog();
931 930
932 // END METHODS DEFINED IN LayoutBlockFlowLine 931 // END METHODS DEFINED IN LayoutBlockFlowLine
933 }; 932 };
934 933
935 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBlockFlow, isLayoutBlockFlow()); 934 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBlockFlow, isLayoutBlockFlow());
936 935
937 } // namespace blink 936 } // namespace blink
938 937
939 #endif // LayoutBlockFlow_h 938 #endif // LayoutBlockFlow_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698