chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java - Issue 2505763002: [NTP] Use OfflineId instead of GUID to identify offline pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Issue 2505763002: [NTP] Use OfflineId instead of GUID to identify offline pages. (Closed)

Patch Set: handle NTP descruction in callbacks. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

index 21bddac55746ee9ea3bf8a9e6fbbf1fb23e82577..7178c3735a6d013d32b4fe8739bff1974e355bfd 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

@@ -57,7 +57,7 @@ import org.chromium.chrome.browser.ntp.cards.NewTabPageRecyclerView;

import org.chromium.chrome.browser.ntp.snippets.SnippetArticle;

import org.chromium.chrome.browser.ntp.snippets.SnippetsConfig;

import org.chromium.chrome.browser.ntp.snippets.SuggestionsSource;

-import org.chromium.chrome.browser.offlinepages.downloads.OfflinePageDownloadBridge;

+import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;

import org.chromium.chrome.browser.profiles.MostVisitedSites.MostVisitedURLsObserver;

import org.chromium.chrome.browser.profiles.Profile;

import org.chromium.chrome.browser.util.MathUtils;

@@ -392,7 +392,7 @@ public class NewTabPageView extends FrameLayout

// Set up snippets

if (mUseCardsUi) {

mNewTabPageAdapter = new NewTabPageAdapter(mManager, mNewTabPageLayout, mUiConfig,

- new OfflinePageDownloadBridge(Profile.getLastUsedProfile()));

+ OfflinePageBridge.getForProfile(Profile.getLastUsedProfile()));

mRecyclerView.setAdapter(mNewTabPageAdapter);

int scrollOffset;