Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1986)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 2505763002: [NTP] Use OfflineId instead of GUID to identify offline pages. (Closed)
Patch Set: handle NTP descruction in callbacks. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
index 4085a2de3e1b700485e86525769e84b636d986e7..8a1b76b9e4e2533131099dc937c00785741330f2 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
@@ -54,7 +54,6 @@ import org.chromium.chrome.browser.ntp.snippets.SnippetsConfig;
import org.chromium.chrome.browser.ntp.snippets.SuggestionsSource;
import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;
import org.chromium.chrome.browser.offlinepages.OfflinePageUtils;
-import org.chromium.chrome.browser.offlinepages.downloads.OfflinePageDownloadBridge;
import org.chromium.chrome.browser.preferences.PrefServiceBridge;
import org.chromium.chrome.browser.profiles.MostVisitedSites;
import org.chromium.chrome.browser.profiles.MostVisitedSites.MostVisitedURLsObserver;
@@ -356,14 +355,19 @@ public class NewTabPage
mSnippetsBridge.onSuggestionOpened(article, windowOpenDisposition);
NewTabPageUma.recordAction(NewTabPageUma.ACTION_OPENED_SNIPPET);
+ // TODO(vitaliii): Propagate OfflineId for offline page downloads from C++.
if (article.isDownload() && article.mIsDownloadedAsset) {
DownloadUtils.openFile(
article.getDownloadAssetFile(), article.getDownloadAssetMimeType(), false);
return;
}
- if (article.getOfflinePageDownloadGuid() != null) {
- OfflinePageDownloadBridge.openDownloadedPage(article.getOfflinePageDownloadGuid());
+ if (article.getOfflinePageOfflineId() != null) {
+ // TODO(vitaliii): Handle other window dispositions.
+ if (windowOpenDisposition == WindowOpenDisposition.CURRENT_TAB) {
+ OfflinePageUtils.openInExistingTab(
+ article.mUrl, article.getOfflinePageOfflineId(), mTab);
+ }
return;
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698