Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Issue 2505763002: [NTP] Use OfflineId instead of GUID to identify offline pages. (Closed)
Patch Set: handle NTP descruction in callbacks. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.ntp; 5 package org.chromium.chrome.browser.ntp;
6 6
7 import android.annotation.SuppressLint; 7 import android.annotation.SuppressLint;
8 import android.content.Context; 8 import android.content.Context;
9 import android.content.res.Configuration; 9 import android.content.res.Configuration;
10 import android.content.res.Resources; 10 import android.content.res.Resources;
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 import org.chromium.chrome.browser.ntp.LogoBridge.LogoObserver; 50 import org.chromium.chrome.browser.ntp.LogoBridge.LogoObserver;
51 import org.chromium.chrome.browser.ntp.MostVisitedItem.MostVisitedItemManager; 51 import org.chromium.chrome.browser.ntp.MostVisitedItem.MostVisitedItemManager;
52 import org.chromium.chrome.browser.ntp.NewTabPage.DestructionObserver; 52 import org.chromium.chrome.browser.ntp.NewTabPage.DestructionObserver;
53 import org.chromium.chrome.browser.ntp.NewTabPage.OnSearchBoxScrollListener; 53 import org.chromium.chrome.browser.ntp.NewTabPage.OnSearchBoxScrollListener;
54 import org.chromium.chrome.browser.ntp.cards.CardsVariationParameters; 54 import org.chromium.chrome.browser.ntp.cards.CardsVariationParameters;
55 import org.chromium.chrome.browser.ntp.cards.NewTabPageAdapter; 55 import org.chromium.chrome.browser.ntp.cards.NewTabPageAdapter;
56 import org.chromium.chrome.browser.ntp.cards.NewTabPageRecyclerView; 56 import org.chromium.chrome.browser.ntp.cards.NewTabPageRecyclerView;
57 import org.chromium.chrome.browser.ntp.snippets.SnippetArticle; 57 import org.chromium.chrome.browser.ntp.snippets.SnippetArticle;
58 import org.chromium.chrome.browser.ntp.snippets.SnippetsConfig; 58 import org.chromium.chrome.browser.ntp.snippets.SnippetsConfig;
59 import org.chromium.chrome.browser.ntp.snippets.SuggestionsSource; 59 import org.chromium.chrome.browser.ntp.snippets.SuggestionsSource;
60 import org.chromium.chrome.browser.offlinepages.downloads.OfflinePageDownloadBri dge; 60 import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;
61 import org.chromium.chrome.browser.profiles.MostVisitedSites.MostVisitedURLsObse rver; 61 import org.chromium.chrome.browser.profiles.MostVisitedSites.MostVisitedURLsObse rver;
62 import org.chromium.chrome.browser.profiles.Profile; 62 import org.chromium.chrome.browser.profiles.Profile;
63 import org.chromium.chrome.browser.util.MathUtils; 63 import org.chromium.chrome.browser.util.MathUtils;
64 import org.chromium.chrome.browser.util.ViewUtils; 64 import org.chromium.chrome.browser.util.ViewUtils;
65 import org.chromium.chrome.browser.widget.RoundedIconGenerator; 65 import org.chromium.chrome.browser.widget.RoundedIconGenerator;
66 import org.chromium.ui.base.DeviceFormFactor; 66 import org.chromium.ui.base.DeviceFormFactor;
67 67
68 import java.util.Arrays; 68 import java.util.Arrays;
69 import java.util.HashSet; 69 import java.util.HashSet;
70 import java.util.Set; 70 import java.util.Set;
(...skipping 314 matching lines...) Expand 10 before | Expand all | Expand 10 after
385 mNewTabPageLayout.addOnLayoutChangeListener(this); 385 mNewTabPageLayout.addOnLayoutChangeListener(this);
386 setSearchProviderHasLogo(searchProviderHasLogo); 386 setSearchProviderHasLogo(searchProviderHasLogo);
387 387
388 mPendingLoadTasks++; 388 mPendingLoadTasks++;
389 mManager.setMostVisitedURLsObserver( 389 mManager.setMostVisitedURLsObserver(
390 this, mMostVisitedDesign.getNumberOfTiles(searchProviderHasLogo) ); 390 this, mMostVisitedDesign.getNumberOfTiles(searchProviderHasLogo) );
391 391
392 // Set up snippets 392 // Set up snippets
393 if (mUseCardsUi) { 393 if (mUseCardsUi) {
394 mNewTabPageAdapter = new NewTabPageAdapter(mManager, mNewTabPageLayo ut, mUiConfig, 394 mNewTabPageAdapter = new NewTabPageAdapter(mManager, mNewTabPageLayo ut, mUiConfig,
395 new OfflinePageDownloadBridge(Profile.getLastUsedProfile())) ; 395 OfflinePageBridge.getForProfile(Profile.getLastUsedProfile() ));
396 mRecyclerView.setAdapter(mNewTabPageAdapter); 396 mRecyclerView.setAdapter(mNewTabPageAdapter);
397 397
398 int scrollOffset; 398 int scrollOffset;
399 if (CardsVariationParameters.isScrollBelowTheFoldEnabled()) { 399 if (CardsVariationParameters.isScrollBelowTheFoldEnabled()) {
400 scrollPosition = mNewTabPageAdapter.getFirstHeaderPosition(); 400 scrollPosition = mNewTabPageAdapter.getFirstHeaderPosition();
401 scrollOffset = getResources().getDimensionPixelSize(R.dimen.ntp_ search_box_height); 401 scrollOffset = getResources().getDimensionPixelSize(R.dimen.ntp_ search_box_height);
402 } else { 402 } else {
403 scrollOffset = 0; 403 scrollOffset = 0;
404 } 404 }
405 mRecyclerView.getLinearLayoutManager().scrollToPositionWithOffset( 405 mRecyclerView.getLinearLayoutManager().scrollToPositionWithOffset(
(...skipping 830 matching lines...) Expand 10 before | Expand all | Expand 10 after
1236 } 1236 }
1237 1237
1238 /** 1238 /**
1239 * @return The adapter position the user has scrolled to. 1239 * @return The adapter position the user has scrolled to.
1240 */ 1240 */
1241 public int getScrollPosition() { 1241 public int getScrollPosition() {
1242 if (mUseCardsUi) return mRecyclerView.getScrollPosition(); 1242 if (mUseCardsUi) return mRecyclerView.getScrollPosition();
1243 return RecyclerView.NO_POSITION; 1243 return RecyclerView.NO_POSITION;
1244 } 1244 }
1245 } 1245 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698