Move const double data out of header file

components/offline_pages/offline_page_storage_manager.cc

Index: components/offline_pages/offline_page_storage_manager.cc
diff --git a/components/offline_pages/offline_page_storage_manager.cc b/components/offline_pages/offline_page_storage_manager.cc
index cc3fd4cd5b7057656144556701aa16e924a98baf..8867fab49011c7e9e9d575ceeebaab9a2347469c 100644
--- a/components/offline_pages/offline_page_storage_manager.cc
+++ b/components/offline_pages/offline_page_storage_manager.cc
@@ -18,6 +18,19 @@ using LifetimeType = offline_pages::LifetimePolicy::LifetimeType;
 
 namespace offline_pages {
 
+// Maximum % of total available storage that will be occupied by offline pages

[fgorski, 2016/11/17 17:10:49]

drop docs from cc. They will be hard to keep in sync with the .h files, where
they are needed.

[brucedawson, 2016/11/17 17:28:56]

Done.

+// before a storage clearup.
+extern const double kOfflinePageStorageLimit = 0.3;

[fgorski, 2016/11/17 17:10:49]

drop the externs from cc. I don't think these are required.

[brucedawson, 2016/11/17 17:28:56]

They are actually required. 'const' implies 'static' (which is why the const
objects in the header didn't cause duplicate declaration errors) so extern is
necessary to indicate that they are supposed to be externally visible.

+// The target % of storage usage we try to reach below when expiring pages.
+extern const double kOfflinePageStorageClearThreshold = 0.1;
+// The time that the storage cleanup will be triggered again since the last one.
+extern const base::TimeDelta kClearStorageInterval =
+    base::TimeDelta::FromMinutes(10);
+// The time that the page record will be removed from the store since the page
+// has been expired.
+extern const base::TimeDelta kRemovePageItemInterval =
+    base::TimeDelta::FromDays(21);
+
 OfflinePageStorageManager::OfflinePageStorageManager(
     OfflinePageModel* model,
     ClientPolicyController* policy_controller,