Move const double data out of header file

Move const double data out of header file

When non-integral const data is defined in a header file it often ends
up being instantiated in multiple translation units. It also ends up in
the read/write data segment which means it isn't shared between
processes. This change has the following affect on the size of sections
in a 32-bit release Windows build:

chrome.dll
     .text:  -432 bytes change
    .rdata:   176 bytes change
     .data:  -128 bytes change
    .reloc:   228 bytes change
Total change:  -156 bytes

Note that the sections that increase in size are either shareable
(.rdata) or discardable (.reloc).

I wish I could use "extern constexpr" to ensure that no constructors are
run, but C++ does not allow that. inline constexpr is not yet supported,
and making the variables a static constexpr member of a class seems like
overkill.

BUG=630755

[brucedawson, 2016-11-17 16:24:17]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 16:24:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2016-11-17 16:51:09]

Description was changed from

==========
Move const double data out of header file

When non-integral const data is defined in a header file it often ends
up being instantiated in multiple translation units. It also ends up in
the read/write data segment which means it isn't shared between
processes. This change has the following affect on the size of sections
in a 32-bit release Windows build:

chrome.dll
     .text:  -432 bytes change
    .rdata:   176 bytes change
     .data:  -128 bytes change
    .reloc:   228 bytes change
Total change:  -156 bytes

I wish I could use "extern constexpr" to ensure that no constructors are
run, but for some reason C++ does not allow that.

BUG=630755
==========

to

==========
Move const double data out of header file

When non-integral const data is defined in a header file it often ends
up being instantiated in multiple translation units. It also ends up in
the read/write data segment which means it isn't shared between
processes. This change has the following affect on the size of sections
in a 32-bit release Windows build:

chrome.dll
     .text:  -432 bytes change
    .rdata:   176 bytes change
     .data:  -128 bytes change
    .reloc:   228 bytes change
Total change:  -156 bytes

I wish I could use "extern constexpr" to ensure that no constructors are
run, but for some reason C++ does not allow that. The results from using
constexpr instead of "extern const" appear to be identical.

BUG=630755
==========

[brucedawson, 2016-11-17 17:10:25]

Description was changed from

==========
Move const double data out of header file

When non-integral const data is defined in a header file it often ends
up being instantiated in multiple translation units. It also ends up in
the read/write data segment which means it isn't shared between
processes. This change has the following affect on the size of sections
in a 32-bit release Windows build:

chrome.dll
     .text:  -432 bytes change
    .rdata:   176 bytes change
     .data:  -128 bytes change
    .reloc:   228 bytes change
Total change:  -156 bytes

I wish I could use "extern constexpr" to ensure that no constructors are
run, but for some reason C++ does not allow that. The results from using
constexpr instead of "extern const" appear to be identical.

BUG=630755
==========

to

==========
Move const double data out of header file

When non-integral const data is defined in a header file it often ends
up being instantiated in multiple translation units. It also ends up in
the read/write data segment which means it isn't shared between
processes. This change has the following affect on the size of sections
in a 32-bit release Windows build:

chrome.dll
     .text:  -432 bytes change
    .rdata:   176 bytes change
     .data:  -128 bytes change
    .reloc:   228 bytes change
Total change:  -156 bytes

I wish I could use "extern constexpr" to ensure that no constructors are
run, but C++ does not allow that. inline constexpr is not yet supported,
and making the variables a static constexpr member of a class seems like
overkill.

BUG=630755
==========

[fgorski, 2016-11-17 17:10:48]

fgorski@chromium.org changed reviewers:
+ fgorski@chromium.org

[fgorski, 2016-11-17 17:10:49]

https://codereview.chromium.org/2505163004/diff/1/components/offline_pages/of...
File components/offline_pages/offline_page_storage_manager.cc (right):

https://codereview.chromium.org/2505163004/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_storage_manager.cc:21: // Maximum % of
total available storage that will be occupied by offline pages
drop docs from cc. They will be hard to keep in sync with the .h files, where
they are needed.

https://codereview.chromium.org/2505163004/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_storage_manager.cc:23: extern const double
kOfflinePageStorageLimit = 0.3;
drop the externs from cc. I don't think these are required.

[brucedawson, 2016-11-17 17:27:08]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 17:27:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2016-11-17 17:28:45]

Description was changed from

==========
Move const double data out of header file

When non-integral const data is defined in a header file it often ends
up being instantiated in multiple translation units. It also ends up in
the read/write data segment which means it isn't shared between
processes. This change has the following affect on the size of sections
in a 32-bit release Windows build:

chrome.dll
     .text:  -432 bytes change
    .rdata:   176 bytes change
     .data:  -128 bytes change
    .reloc:   228 bytes change
Total change:  -156 bytes

I wish I could use "extern constexpr" to ensure that no constructors are
run, but C++ does not allow that. inline constexpr is not yet supported,
and making the variables a static constexpr member of a class seems like
overkill.

BUG=630755
==========

to

==========
Move const double data out of header file

When non-integral const data is defined in a header file it often ends
up being instantiated in multiple translation units. It also ends up in
the read/write data segment which means it isn't shared between
processes. This change has the following affect on the size of sections
in a 32-bit release Windows build:

chrome.dll
     .text:  -432 bytes change
    .rdata:   176 bytes change
     .data:  -128 bytes change
    .reloc:   228 bytes change
Total change:  -156 bytes

Note that the sections that increase in size are either shareable
(.rdata) or discardable (.reloc).

I wish I could use "extern constexpr" to ensure that no constructors are
run, but C++ does not allow that. inline constexpr is not yet supported,
and making the variables a static constexpr member of a class seems like
overkill.

BUG=630755
==========

[brucedawson, 2016-11-17 17:28:57]

https://codereview.chromium.org/2505163004/diff/1/components/offline_pages/of...
File components/offline_pages/offline_page_storage_manager.cc (right):

https://codereview.chromium.org/2505163004/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_storage_manager.cc:21: // Maximum % of
total available storage that will be occupied by offline pages
On 2016/11/17 17:10:49, fgorski wrote:
> drop docs from cc. They will be hard to keep in sync with the .h files, where
> they are needed.

Done.

https://codereview.chromium.org/2505163004/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_storage_manager.cc:23: extern const double
kOfflinePageStorageLimit = 0.3;
On 2016/11/17 17:10:49, fgorski wrote:
> drop the externs from cc. I don't think these are required.

They are actually required. 'const' implies 'static' (which is why the const
objects in the header didn't cause duplicate declaration errors) so extern is
necessary to indicate that they are supposed to be externally visible.

[commit-bot: I haz the power, 2016-11-17 18:34:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 18:34:44]

Dry run: This issue passed the CQ dry run.