Move const double data out of header file

components/offline_pages/offline_page_storage_manager.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/offline_page_storage_manager.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/time/clock.h"
 #include "base/time/default_clock.h"
 #include "components/offline_pages/client_policy_controller.h"
 #include "components/offline_pages/offline_page_client_policy.h"
 #include "components/offline_pages/offline_page_item.h"
 #include "components/offline_pages/offline_page_model.h"
 
 using LifetimeType = offline_pages::LifetimePolicy::LifetimeType;
 
 namespace offline_pages {
 
+// Maximum % of total available storage that will be occupied by offline pages

[fgorski, 2016/11/17 17:10:49]

drop docs from cc. They will be hard to keep in sync with the .h files, where
they are needed.

[brucedawson, 2016/11/17 17:28:56]

Done.

+// before a storage clearup.
+extern const double kOfflinePageStorageLimit = 0.3;

[fgorski, 2016/11/17 17:10:49]

drop the externs from cc. I don't think these are required.

[brucedawson, 2016/11/17 17:28:56]

They are actually required. 'const' implies 'static' (which is why the const
objects in the header didn't cause duplicate declaration errors) so extern is
necessary to indicate that they are supposed to be externally visible.

+// The target % of storage usage we try to reach below when expiring pages.
+extern const double kOfflinePageStorageClearThreshold = 0.1;
+// The time that the storage cleanup will be triggered again since the last one.
+extern const base::TimeDelta kClearStorageInterval =
+    base::TimeDelta::FromMinutes(10);
+// The time that the page record will be removed from the store since the page
+// has been expired.
+extern const base::TimeDelta kRemovePageItemInterval =
+    base::TimeDelta::FromDays(21);
+
 OfflinePageStorageManager::OfflinePageStorageManager(
     OfflinePageModel* model,
     ClientPolicyController* policy_controller,
     ArchiveManager* archive_manager)
     : model_(model),
       policy_controller_(policy_controller),
       archive_manager_(archive_manager),
       clock_(new base::DefaultClock()),
       weak_ptr_factory_(this) {}
 
@@ skipping 174 matching lines @@
       policy_controller_->GetPolicy(page.client_id.name_space).lifetime_policy;
   return policy.lifetime_type == LifetimeType::TEMPORARY &&
          clear_time_ - page.last_access_time >= policy.expiration_period;
 }
 
 bool OfflinePageStorageManager::IsInProgress() const {
   return clear_time_ > last_clear_time_;
 }
 
 }  // namespace offline_pages