Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2504913003: [turbofan] track source positions in EffectControlLinearizer (Closed)

Created:
4 years, 1 month ago by Tobias Tebbi
Modified:
4 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] track source positions in EffectControlLinearizer R=jarin@chromium.org BUG= Committed: https://crrev.com/d2a64c817e8a6f5ad170fde2a1fdf58a204322c2 Cr-Commit-Position: refs/heads/master@{#41040}

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -14 lines) Patch
M src/compiler/effect-control-linearizer.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M src/compiler/effect-control-linearizer.cc View 1 6 chunks +16 lines, -6 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/unittests/compiler/effect-control-linearizer-unittest.cc View 1 7 chunks +16 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Tobias Tebbi
4 years, 1 month ago (2016-11-16 12:38:52 UTC) #1
Jarin
lgtm https://codereview.chromium.org/2504913003/diff/1/src/compiler/effect-control-linearizer.cc File src/compiler/effect-control-linearizer.cc (right): https://codereview.chromium.org/2504913003/diff/1/src/compiler/effect-control-linearizer.cc#newcode461 src/compiler/effect-control-linearizer.cc:461: &block_effects); Does not this only need the source ...
4 years, 1 month ago (2016-11-16 13:32:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504913003/20001
4 years, 1 month ago (2016-11-16 14:35:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504913003/20001
4 years, 1 month ago (2016-11-16 14:36:38 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-16 15:06:11 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:36:32 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d2a64c817e8a6f5ad170fde2a1fdf58a204322c2
Cr-Commit-Position: refs/heads/master@{#41040}

Powered by Google App Engine
This is Rietveld 408576698