[turbofan] track source positions in EffectControlLinearizer

test/unittests/compiler/effect-control-linearizer-unittest.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/effect-control-linearizer.h"
 #include "src/compiler/access-builder.h"
+#include "src/compiler/compiler-source-position-table.h"
 #include "src/compiler/js-graph.h"
 #include "src/compiler/linkage.h"
 #include "src/compiler/node-properties.h"
 #include "src/compiler/schedule.h"
 #include "src/compiler/simplified-operator.h"
 #include "test/unittests/compiler/graph-unittest.h"
 #include "test/unittests/compiler/node-test-utils.h"
 #include "test/unittests/test-utils.h"
 #include "testing/gmock-support.h"
 #include "testing/gmock/include/gmock/gmock.h"
 
 namespace v8 {
 namespace internal {
 namespace compiler {
 
 using testing::Capture;
 
 class EffectControlLinearizerTest : public GraphTest {
  public:
   EffectControlLinearizerTest()
       : GraphTest(3),
         machine_(zone()),
         javascript_(zone()),
         simplified_(zone()),
         jsgraph_(isolate(), graph(), common(), &javascript_, &simplified_,
-                 &machine_) {}
+                 &machine_) {
+    source_positions_ = new (zone()) SourcePositionTable(graph());
+  }
 
   JSGraph* jsgraph() { return &jsgraph_; }
   SimplifiedOperatorBuilder* simplified() { return &simplified_; }
+  SourcePositionTable* source_positions() { return source_positions_; }
 
  private:
   MachineOperatorBuilder machine_;
   JSOperatorBuilder javascript_;
   SimplifiedOperatorBuilder simplified_;
   JSGraph jsgraph_;
+  SourcePositionTable* source_positions_;
 };
 
 namespace {
 
 BasicBlock* AddBlockToSchedule(Schedule* schedule) {
   BasicBlock* block = schedule->NewBasicBlock();
   block->set_rpo_number(static_cast<int32_t>(schedule->rpo_order()->size()));
   schedule->rpo_order()->push_back(block);
   return block;
 }
@@ skipping 17 matching lines @@
   schedule.rpo_order()->push_back(start);
   start->set_rpo_number(0);
 
   // Populate the basic blocks with nodes.
   schedule.AddNode(start, graph()->start());
   schedule.AddNode(start, heap_number);
   schedule.AddNode(start, load);
   schedule.AddReturn(start, ret);
 
   // Run the state effect introducer.
-  EffectControlLinearizer introducer(jsgraph(), &schedule, zone());
+  EffectControlLinearizer introducer(jsgraph(), &schedule, zone(),
+                                     source_positions());
   introducer.Run();
 
   EXPECT_THAT(load,
               IsLoadField(AccessBuilder::ForHeapNumberValue(), heap_number,
                           graph()->start(), graph()->start()));
   // The return should have reconnected effect edge to the load.
   EXPECT_THAT(ret, IsReturn(load, load, graph()->start()));
 }
 
 TEST_F(EffectControlLinearizerTest, DiamondLoad) {
@@ skipping 40 matching lines @@
 
   schedule.AddNode(fblock, if_false);
   schedule.AddNode(fblock, vfalse);
   schedule.AddGoto(fblock, mblock);
 
   schedule.AddNode(mblock, merge);
   schedule.AddNode(mblock, phi);
   schedule.AddReturn(mblock, ret);
 
   // Run the state effect introducer.
-  EffectControlLinearizer introducer(jsgraph(), &schedule, zone());
+  EffectControlLinearizer introducer(jsgraph(), &schedule, zone(),
+                                     source_positions());
   introducer.Run();
 
   // The effect input to the return should be an effect phi with the
   // newly introduced effectful change operators.
   ASSERT_THAT(
       ret, IsReturn(phi, IsEffectPhi(vtrue, graph()->start(), merge), merge));
 }
 
 TEST_F(EffectControlLinearizerTest, FloatingDiamondsControlWiring) {
   Schedule schedule(zone());
@@ skipping 97 matching lines @@
   schedule.AddNode(t2block, if_true2);
   schedule.AddGoto(t2block, m2block);
 
   schedule.AddNode(f2block, if_false2);
   schedule.AddGoto(f2block, m2block);
 
   schedule.AddNode(m2block, merge2);
   schedule.AddReturn(m2block, ret);
 
   // Run the state effect introducer.
-  EffectControlLinearizer introducer(jsgraph(), &schedule, zone());
+  EffectControlLinearizer introducer(jsgraph(), &schedule, zone(),
+                                     source_positions());
   introducer.Run();
 
   // The effect input to the return should be an effect phi with the
   // newly introduced effectful change operators.
   ASSERT_THAT(ret, IsReturn(call, call, merge2));
   ASSERT_THAT(branch2, IsBranch(const0, merge1));
   ASSERT_THAT(branch1, IsBranch(const0, if_success));
   ASSERT_THAT(if_success, IsIfSuccess(call));
 }
 
@@ skipping 47 matching lines @@
   schedule.AddNode(lblock, cond);
   schedule.AddBranch(lblock, branch, rblock, fblock);
 
   schedule.AddNode(fblock, if_false);
   schedule.AddGoto(fblock, lblock);
 
   schedule.AddNode(rblock, if_true);
   schedule.AddReturn(rblock, ret);
 
   // Run the state effect introducer.
-  EffectControlLinearizer introducer(jsgraph(), &schedule, zone());
+  EffectControlLinearizer introducer(jsgraph(), &schedule, zone(),
+                                     source_positions());
   introducer.Run();
 
   ASSERT_THAT(ret, IsReturn(load, load, if_true));
   EXPECT_THAT(load, IsLoadField(AccessBuilder::ForHeapNumberValue(),
                                 heap_number, effect_phi, loop));
 }
 
 TEST_F(EffectControlLinearizerTest, CloneBranch) {
   Schedule schedule(zone());
 
@@ skipping 41 matching lines @@
 
   schedule.AddNode(t2block, if_true);
   schedule.AddGoto(t2block, mblock);
 
   schedule.AddNode(f2block, if_false);
   schedule.AddGoto(f2block, mblock);
 
   schedule.AddNode(mblock, merge);
   schedule.AddNode(mblock, graph()->end());
 
-  EffectControlLinearizer introducer(jsgraph(), &schedule, zone());
+  EffectControlLinearizer introducer(jsgraph(), &schedule, zone(),
+                                     source_positions());
   introducer.Run();
 
   Capture<Node *> branch1_capture, branch2_capture;
   EXPECT_THAT(
       end(),
       IsEnd(IsMerge(IsMerge(IsIfTrue(CaptureEq(&branch1_capture)),
                             IsIfTrue(CaptureEq(&branch2_capture))),
                     IsMerge(IsIfFalse(AllOf(CaptureEq(&branch1_capture),
                                             IsBranch(cond1, control1))),
                             IsIfFalse(AllOf(CaptureEq(&branch2_capture),
                                             IsBranch(cond2, control2)))))));
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8