Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Unified Diff: test/unittests/compiler/effect-control-linearizer-unittest.cc

Issue 2504913003: [turbofan] track source positions in EffectControlLinearizer (Closed)
Patch Set: addressed comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/pipeline.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/compiler/effect-control-linearizer-unittest.cc
diff --git a/test/unittests/compiler/effect-control-linearizer-unittest.cc b/test/unittests/compiler/effect-control-linearizer-unittest.cc
index cc697734a9872253e7cf43a1c681bf37c2de9f66..3aee3a832f636a7e0a9cca9ce4457c1644bc24c4 100644
--- a/test/unittests/compiler/effect-control-linearizer-unittest.cc
+++ b/test/unittests/compiler/effect-control-linearizer-unittest.cc
@@ -4,6 +4,7 @@
#include "src/compiler/effect-control-linearizer.h"
#include "src/compiler/access-builder.h"
+#include "src/compiler/compiler-source-position-table.h"
#include "src/compiler/js-graph.h"
#include "src/compiler/linkage.h"
#include "src/compiler/node-properties.h"
@@ -29,16 +30,20 @@ class EffectControlLinearizerTest : public GraphTest {
javascript_(zone()),
simplified_(zone()),
jsgraph_(isolate(), graph(), common(), &javascript_, &simplified_,
- &machine_) {}
+ &machine_) {
+ source_positions_ = new (zone()) SourcePositionTable(graph());
+ }
JSGraph* jsgraph() { return &jsgraph_; }
SimplifiedOperatorBuilder* simplified() { return &simplified_; }
+ SourcePositionTable* source_positions() { return source_positions_; }
private:
MachineOperatorBuilder machine_;
JSOperatorBuilder javascript_;
SimplifiedOperatorBuilder simplified_;
JSGraph jsgraph_;
+ SourcePositionTable* source_positions_;
};
namespace {
@@ -76,7 +81,8 @@ TEST_F(EffectControlLinearizerTest, SimpleLoad) {
schedule.AddReturn(start, ret);
// Run the state effect introducer.
- EffectControlLinearizer introducer(jsgraph(), &schedule, zone());
+ EffectControlLinearizer introducer(jsgraph(), &schedule, zone(),
+ source_positions());
introducer.Run();
EXPECT_THAT(load,
@@ -137,7 +143,8 @@ TEST_F(EffectControlLinearizerTest, DiamondLoad) {
schedule.AddReturn(mblock, ret);
// Run the state effect introducer.
- EffectControlLinearizer introducer(jsgraph(), &schedule, zone());
+ EffectControlLinearizer introducer(jsgraph(), &schedule, zone(),
+ source_positions());
introducer.Run();
// The effect input to the return should be an effect phi with the
@@ -255,7 +262,8 @@ TEST_F(EffectControlLinearizerTest, FloatingDiamondsControlWiring) {
schedule.AddReturn(m2block, ret);
// Run the state effect introducer.
- EffectControlLinearizer introducer(jsgraph(), &schedule, zone());
+ EffectControlLinearizer introducer(jsgraph(), &schedule, zone(),
+ source_positions());
introducer.Run();
// The effect input to the return should be an effect phi with the
@@ -323,7 +331,8 @@ TEST_F(EffectControlLinearizerTest, LoopLoad) {
schedule.AddReturn(rblock, ret);
// Run the state effect introducer.
- EffectControlLinearizer introducer(jsgraph(), &schedule, zone());
+ EffectControlLinearizer introducer(jsgraph(), &schedule, zone(),
+ source_positions());
introducer.Run();
ASSERT_THAT(ret, IsReturn(load, load, if_true));
@@ -385,7 +394,8 @@ TEST_F(EffectControlLinearizerTest, CloneBranch) {
schedule.AddNode(mblock, merge);
schedule.AddNode(mblock, graph()->end());
- EffectControlLinearizer introducer(jsgraph(), &schedule, zone());
+ EffectControlLinearizer introducer(jsgraph(), &schedule, zone(),
+ source_positions());
introducer.Run();
Capture<Node *> branch1_capture, branch2_capture;
« no previous file with comments | « src/compiler/pipeline.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698