Merge provisioning success/error handling.

Merge provisioning success/error handling.

This CL merges all provisioning success and error handling
into OnProvisioningFinished().
The function will be the callback after ArcAuthService separation.

BUG=657687
BUG=b/31079732
TEST=Trybots. Ran on test device.

Committed: https://crrev.com/61e0e4de34b41832362b3ba8f15054f2f280926d
Cr-Commit-Position: refs/heads/master@{#432844}

[hidehiko, 2016-11-15 13:07:21]

hidehiko@chromium.org changed reviewers:
+ lhchavez@chromium.org

[hidehiko, 2016-11-15 13:07:21]

Preparation of separating ArcSessionManager and ArcAuthService. PTAL.

[Luis Héctor Chávez, 2016-11-15 23:40:50]

lgtm with nits

https://codereview.chromium.org/2504583002/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/arc_auth_service.cc (right):

https://codereview.chromium.org/2504583002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_auth_service.cc:459: // For backword
compatibility, use NETWORK_ERROR for
nit: s/backword/backwards/

https://codereview.chromium.org/2504583002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_auth_service.cc:470: if (result !=
ProvisioningResult::SUCCESS) {
nit: you can elide braces

https://codereview.chromium.org/2504583002/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/arc_auth_service.h (right):

https://codereview.chromium.org/2504583002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_auth_service.h:245: void
OnProvisioningFinished(ProvisioningResult result);
Can this be private?

[hidehiko, 2016-11-17 11:04:54]

Thank you for review. Submitting.

https://codereview.chromium.org/2504583002/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/arc_auth_service.cc (right):

https://codereview.chromium.org/2504583002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_auth_service.cc:459: // For backword
compatibility, use NETWORK_ERROR for
On 2016/11/15 23:40:50, Luis Héctor Chávez wrote:
> nit: s/backword/backwards/

Done.

https://codereview.chromium.org/2504583002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_auth_service.cc:470: if (result !=
ProvisioningResult::SUCCESS) {
On 2016/11/15 23:40:50, Luis Héctor Chávez wrote:
> nit: you can elide braces

Done.

https://codereview.chromium.org/2504583002/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/arc_auth_service.h (right):

https://codereview.chromium.org/2504583002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_auth_service.h:245: void
OnProvisioningFinished(ProvisioningResult result);
On 2016/11/15 23:40:50, Luis Héctor Chávez wrote:
> Can this be private?

In this CL, we can move it to private. However, in a following CL you've already
LGTM'ed, we need to move back to public. So let me keep this in public.

[hidehiko, 2016-11-17 11:05:03]

The CQ bit was checked by hidehiko@chromium.org

[hidehiko, 2016-11-17 11:05:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
lhchavez@chromium.org
Link to the patchset: https://codereview.chromium.org/2504583002/#ps40001
(title: "Address comments.")

[commit-bot: I haz the power, 2016-11-17 11:05:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 11:33:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-17 11:36:12]

Description was changed from

==========
Merge provisioning success/error handling.

This CL merges all provisioning success and error handling
into OnProvisioningFinished().
The function will be the callback after ArcAuthService separation.

BUG=657687
BUG=b/31079732
TEST=Trybots. Ran on test device.
==========

to

==========
Merge provisioning success/error handling.

This CL merges all provisioning success and error handling
into OnProvisioningFinished().
The function will be the callback after ArcAuthService separation.

BUG=657687
BUG=b/31079732
TEST=Trybots. Ran on test device.

Committed: https://crrev.com/61e0e4de34b41832362b3ba8f15054f2f280926d
Cr-Commit-Position: refs/heads/master@{#432844}
==========

[commit-bot: I haz the power, 2016-11-17 11:36:13]

Patchset 3 (id:??) landed as
https://crrev.com/61e0e4de34b41832362b3ba8f15054f2f280926d
Cr-Commit-Position: refs/heads/master@{#432844}