chrome/browser/chromeos/arc/arc_optin_uma.cc - Issue 2504583002: Merge provisioning success/error handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/arc/arc_optin_uma.cc

Issue 2504583002: Merge provisioning success/error handling. (Closed)

Patch Set: Address comments. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/arc/arc_optin_uma.cc

diff --git a/chrome/browser/chromeos/arc/arc_optin_uma.cc b/chrome/browser/chromeos/arc/arc_optin_uma.cc

index 0a16f5e449f0a70b52836f0d35374f2a11b6b151..f350e09263683a4f4238b8b47b4f4c4dc8deb60b 100644

--- a/chrome/browser/chromeos/arc/arc_optin_uma.cc

+++ b/chrome/browser/chromeos/arc/arc_optin_uma.cc

@@ -23,6 +23,7 @@ void UpdateEnabledStateUMA(bool enabled) {

}

void UpdateProvisioningResultUMA(ProvisioningResult result, bool managed) {

+ DCHECK_NE(result, ProvisioningResult::CHROME_SERVER_COMMUNICATION_ERROR);

std::string histogram_name = "Arc.Provisioning.Result.";

histogram_name += managed ? "Managed" : "Unmanaged";

base::LinearHistogram::FactoryGet(

« no previous file with comments | « chrome/browser/chromeos/arc/arc_optin_uma.h ('k') | no next file » | no next file with comments »