Merge provisioning success/error handling.

chrome/browser/chromeos/arc/arc_auth_service.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_ARC_ARC_AUTH_SERVICE_H_
 #define CHROME_BROWSER_CHROMEOS_ARC_ARC_AUTH_SERVICE_H_
 
 #include <memory>
 #include <ostream>
 #include <string>
@@ skipping 163 matching lines @@
       const GetAuthCodeDeprecated0Callback& callback) override;
   void GetAuthCodeDeprecated(
       const GetAuthCodeDeprecatedCallback& callback) override;
   void GetAuthCodeAndAccountTypeDeprecated(
       const GetAuthCodeAndAccountTypeDeprecatedCallback& callback) override;
   // Callback is called with a bool that indicates the management status of the
   // user.
   void GetIsAccountManagedDeprecated(
       const GetIsAccountManagedDeprecatedCallback& callback) override;
 
-  void OnSignInFailedInternal(ProvisioningResult result);
-
   // Called from Arc support platform app to set auth code and start arc.
   void OnAuthCodeObtained(const std::string& auth_code);
 
   // Called from Arc support platform app when user cancels signing.
   void CancelAuthCode();
 
   bool IsArcManaged() const;
   bool IsArcEnabled() const;
 
   // This requires Arc to be allowed (|IsAllowed|)for current profile.
@@ skipping 41 matching lines @@
   void StopAndEnableArc();
 
   // Removes the data if ARC is stopped. Otherwise, queue to remove the data
   // on ARC is stopped.
   void RemoveArcData();
 
   ArcSupportHost* support_host() { return support_host_.get(); }
 
   void StartArc();
 
+  void OnProvisioningFinished(ProvisioningResult result);

[Luis Héctor Chávez, 2016/11/15 23:40:50]

Can this be private?

[hidehiko, 2016/11/17 11:04:54]

In this CL, we can move it to private. However, in a following CL you've already
LGTM'ed, we need to move back to public. So let me keep this in public.

+
  private:
   using AccountInfoCallback = base::Callback<void(mojom::AccountInfoPtr)>;
   class AccountInfoNotifier;
 
   // TODO(hidehiko): move UI methods/fields to ArcSupportHost.
   void SetState(State state);
   void ShutdownBridge();
   void OnOptInPreferenceChanged();
   void StartUI();
   void OnAndroidManagementPassed();
@@ skipping 54 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(ArcAuthService);
 };
 
 // Outputs the stringified |state| to |os|. This is only for logging purposes.
 std::ostream& operator<<(std::ostream& os, const ArcAuthService::State& state);
 
 }  // namespace arc
 
 #endif  // CHROME_BROWSER_CHROMEOS_ARC_ARC_AUTH_SERVICE_H_