Page Info (native Mac): Change "Details" link (sec. panel) to "Learn more" (help center).

Page Info (native Mac): Change "Details" link (sec. panel) to "Learn more" (help center).

This CL also removes the isDevToolsDisabled boolean calculation, which was
(only) used to show the Details button conditionally.

BUG=646465
NO_DEPENDENCY_CHECKS=true
TEST=
1) Visit https://google.com
2) Click on the lock icon in the omnibox.
3) Verify that there is a link with the text "Learn more"
4) Verify that the link opens the Chrome Help Center page titled "Check Chrome's connection to a site" [1]

[1] https://support.google.com/chrome/answer/95617?hl=en

Committed: https://crrev.com/7ef72beedd573b8a81ad2f88e53f760c87bc34f1
Cr-Commit-Position: refs/heads/master@{#433962}

[lgarron, 2016-11-15 00:47:47]

Patchset #1 (id:1) has been deleted

[lgarron, 2016-11-15 00:49:50]

Description was changed from

==========
Mac Page Info: Change "Details" link (sec. panel) to "Learn more" (help center).

BUG=646465
==========

to

==========
Mac Page Info: Change "Details" link (sec. panel) to "Learn more" (help center).

This CL also removes the isDevToolsDisabled boolean calculation, which was
(only) used to show the Details button conditionally.

BUG=646465
TEST=
1) Visit https://google.com
2) Click on the lock icon in the omnibox.
3) Verify that there is a link with the text "Learn more"
4) Verify that the link opens the Chrome Help Center page titled "Check Chrome's
connection to a site" [1]

[1] https://support.google.com/chrome/answer/95617?hl=en
==========

[lgarron, 2016-11-15 00:50:04]

lgarron@chromium.org changed reviewers:
+ rsesek@chromium.org

[lgarron, 2016-11-15 00:50:04]

rsesek@, could you review?

[lgarron, 2016-11-15 00:50:58]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 00:51:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lgarron, 2016-11-15 00:51:43]

Description was changed from

==========
Mac Page Info: Change "Details" link (sec. panel) to "Learn more" (help center).

This CL also removes the isDevToolsDisabled boolean calculation, which was
(only) used to show the Details button conditionally.

BUG=646465
TEST=
1) Visit https://google.com
2) Click on the lock icon in the omnibox.
3) Verify that there is a link with the text "Learn more"
4) Verify that the link opens the Chrome Help Center page titled "Check Chrome's
connection to a site" [1]

[1] https://support.google.com/chrome/answer/95617?hl=en
==========

to

==========
Page Info (native Mac): Change "Details" link (sec. panel) to "Learn more" (help
center).

This CL also removes the isDevToolsDisabled boolean calculation, which was
(only) used to show the Details button conditionally.

BUG=646465
TEST=
1) Visit https://google.com
2) Click on the lock icon in the omnibox.
3) Verify that there is a link with the text "Learn more"
4) Verify that the link opens the Chrome Help Center page titled "Check Chrome's
connection to a site" [1]

[1] https://support.google.com/chrome/answer/95617?hl=en
==========

[Robert Sesek, 2016-11-15 14:37:35]

LGTM

[lgarron, 2016-11-22 02:11:33]

The CQ bit was checked by lgarron@chromium.org

[lgarron, 2016-11-22 02:11:33]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/2504453003/#ps80001
(title: "Rebase to tip of tree.")

[commit-bot: I haz the power, 2016-11-22 02:12:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 02:12:10]

This CL has an open dependency (Issue 2506473002 Patch 60001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[lgarron, 2016-11-22 02:28:34]

Description was changed from

==========
Page Info (native Mac): Change "Details" link (sec. panel) to "Learn more" (help
center).

This CL also removes the isDevToolsDisabled boolean calculation, which was
(only) used to show the Details button conditionally.

BUG=646465
TEST=
1) Visit https://google.com
2) Click on the lock icon in the omnibox.
3) Verify that there is a link with the text "Learn more"
4) Verify that the link opens the Chrome Help Center page titled "Check Chrome's
connection to a site" [1]

[1] https://support.google.com/chrome/answer/95617?hl=en
==========

to

==========
Page Info (native Mac): Change "Details" link (sec. panel) to "Learn more" (help
center).

This CL also removes the isDevToolsDisabled boolean calculation, which was
(only) used to show the Details button conditionally.

BUG=646465
NO_DEPENDENCY_CHECKS=true
TEST=
1) Visit https://google.com
2) Click on the lock icon in the omnibox.
3) Verify that there is a link with the text "Learn more"
4) Verify that the link opens the Chrome Help Center page titled "Check Chrome's
connection to a site" [1]

[1] https://support.google.com/chrome/answer/95617?hl=en
==========

[lgarron, 2016-11-22 02:29:00]

Retrying with NO_DEPENDENCY_CHECKS=true because the dependency has been removed,
but I can't push a fixed patch due to auth issues.

[lgarron, 2016-11-22 02:29:02]

The CQ bit was checked by lgarron@chromium.org

[commit-bot: I haz the power, 2016-11-22 02:29:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lgarron, 2016-11-22 02:31:06]

The CQ bit was checked by lgarron@chromium.org

[lgarron, 2016-11-22 02:31:06]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/2504453003/#ps100001
(title: "Remove dependency.")

[commit-bot: I haz the power, 2016-11-22 02:32:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 03:03:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 03:03:16]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[lgarron, 2016-11-22 03:47:35]

The CQ bit was checked by lgarron@chromium.org

[lgarron, 2016-11-22 03:47:35]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/2504453003/#ps120001
(title: "Rebase string identifier.")

[commit-bot: I haz the power, 2016-11-22 03:47:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 04:22:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 04:22:12]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[lgarron, 2016-11-22 17:32:12]

The CQ bit was checked by lgarron@chromium.org

[lgarron, 2016-11-22 17:32:13]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/2504453003/#ps140001
(title: "Fix test.")

[commit-bot: I haz the power, 2016-11-22 17:32:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 17:58:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 17:58:51]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[lgarron, 2016-11-22 19:32:17]

The CQ bit was checked by lgarron@chromium.org

[lgarron, 2016-11-22 19:32:18]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/2504453003/#ps160001
(title: "Page Info (native Mac): Change "Details" link (sec. panel) to "Learn
more" (help center).")

[commit-bot: I haz the power, 2016-11-22 19:32:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 20:22:55]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1479843137765470,
"parent_rev": "23a8db918158adee0a816e586f372bf372850b2f", "commit_rev":
"96213cc78b788401e9e3ca35afd3702da7316416"}

[commit-bot: I haz the power, 2016-11-22 20:23:19]

Committed patchset #8 (id:160001)

[commit-bot: I haz the power, 2016-11-22 20:26:01]

Description was changed from

==========
Page Info (native Mac): Change "Details" link (sec. panel) to "Learn more" (help
center).

This CL also removes the isDevToolsDisabled boolean calculation, which was
(only) used to show the Details button conditionally.

BUG=646465
NO_DEPENDENCY_CHECKS=true
TEST=
1) Visit https://google.com
2) Click on the lock icon in the omnibox.
3) Verify that there is a link with the text "Learn more"
4) Verify that the link opens the Chrome Help Center page titled "Check Chrome's
connection to a site" [1]

[1] https://support.google.com/chrome/answer/95617?hl=en
==========

to

==========
Page Info (native Mac): Change "Details" link (sec. panel) to "Learn more" (help
center).

This CL also removes the isDevToolsDisabled boolean calculation, which was
(only) used to show the Details button conditionally.

BUG=646465
NO_DEPENDENCY_CHECKS=true
TEST=
1) Visit https://google.com
2) Click on the lock icon in the omnibox.
3) Verify that there is a link with the text "Learn more"
4) Verify that the link opens the Chrome Help Center page titled "Check Chrome's
connection to a site" [1]

[1] https://support.google.com/chrome/answer/95617?hl=en

Committed: https://crrev.com/7ef72beedd573b8a81ad2f88e53f760c87bc34f1
Cr-Commit-Position: refs/heads/master@{#433962}
==========

[commit-bot: I haz the power, 2016-11-22 20:26:02]

Patchset 8 (id:??) landed as
https://crrev.com/7ef72beedd573b8a81ad2f88e53f760c87bc34f1
Cr-Commit-Position: refs/heads/master@{#433962}