Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm

Issue 2504453003: Page Info (native Mac): Change "Details" link (sec. panel) to "Learn more" (help center). (Closed)
Patch Set: Page Info (native Mac): Change "Details" link (sec. panel) to "Learn more" (help center). Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm
index 3717ac2f8f80653994019fa3a569bb6d347cc33f..1994c84b49de3d1785f9e98619f22eb4c1066801 100644
--- a/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm
@@ -19,7 +19,7 @@
@interface WebsiteSettingsBubbleController (ExposedForTesting)
- (NSView*)permissionsView;
- (NSButton*)resetDecisionsButton;
-- (NSButton*)securityDetailsButton;
+- (NSButton*)connectionHelpButton;
@end
@implementation WebsiteSettingsBubbleController (ExposedForTesting)
@@ -29,8 +29,9 @@
- (NSButton*)resetDecisionsButton {
return resetDecisionsButton_;
}
-- (NSButton*)securityDetailsButton {
- return securityDetailsButton_;
+- (NSButton*)connectionHelpButton {
+
+ return connectionHelpButton_;
}
@end
@@ -127,8 +128,7 @@ class WebsiteSettingsBubbleControllerTest : public CocoaTest {
websiteSettingsUIBridge:bridge_
webContents:web_contents_factory_.CreateWebContents(
&profile_)
- url:GURL("https://www.google.com")
- isDevToolsDisabled:NO];
+ url:GURL("https://www.google.com")];
window_ = [controller_ window];
[controller_ showWindow:nil];
}
@@ -206,7 +206,7 @@ class WebsiteSettingsBubbleControllerTest : public CocoaTest {
NSWindow* window_; // Weak, owned by controller.
};
-TEST_F(WebsiteSettingsBubbleControllerTest, SecurityDetailsButton) {
+TEST_F(WebsiteSettingsBubbleControllerTest, ConnectionHelpButton) {
WebsiteSettingsUI::IdentityInfo info;
info.site_identity = std::string("example.com");
info.identity_status = WebsiteSettings::SITE_IDENTITY_STATUS_UNKNOWN;
@@ -215,8 +215,8 @@ TEST_F(WebsiteSettingsBubbleControllerTest, SecurityDetailsButton) {
bridge_->SetIdentityInfo(const_cast<WebsiteSettingsUI::IdentityInfo&>(info));
- EXPECT_EQ([[controller_ securityDetailsButton] action],
- @selector(showSecurityDetails:));
+ EXPECT_EQ([[controller_ connectionHelpButton] action],
+ @selector(openConnectionHelp:));
}
TEST_F(WebsiteSettingsBubbleControllerTest, ResetDecisionsButton) {
« no previous file with comments | « chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698