Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4279)

Unified Diff: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h

Issue 2504453003: Page Info (native Mac): Change "Details" link (sec. panel) to "Learn more" (help center). (Closed)
Patch Set: Page Info (native Mac): Change "Details" link (sec. panel) to "Learn more" (help center). Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h
diff --git a/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h
index fd10658d0615bb964c1175e36965839acc8e453d..10bfdff37af4c7650b0999b92540384e7a0c657a 100644
--- a/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h
+++ b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h
@@ -48,10 +48,9 @@ struct SecurityInfo;
// user should treat it.
NSTextField* securityDetailsField_;
- // The link button for opening security details for the page. This is the
- // DevTools Security panel for most users, but may be the certificate viewer
- // for enterprise users with DevTools disabled.
- NSButton* securityDetailsButton_;
+ // The link button for opening a Chrome Help Center page explaining connection
+ // security.
+ NSButton* connectionHelpButton_;
// URL of the page for which the bubble is shown.
GURL url_;
@@ -66,9 +65,6 @@ struct SecurityInfo;
// This link only shows when there is an acrive certificate exception.
NSButton* resetDecisionsButton_;
- // Whether DevTools is disabled for the relevant profile.
- BOOL isDevToolsDisabled_;
-
// The server certificate from the identity info. This should always be
// non-null on a cryptographic connection, and null otherwise.
scoped_refptr<net::X509Certificate> certificate_;
@@ -106,8 +102,7 @@ struct SecurityInfo;
- (id)initWithParentWindow:(NSWindow*)parentWindow
websiteSettingsUIBridge:(WebsiteSettingsUIBridge*)bridge
webContents:(content::WebContents*)webContents
- url:(const GURL&)url
- isDevToolsDisabled:(BOOL)isDevToolsDisabled;
+ url:(const GURL&)url;
// Return the default width of the window. It may be wider to fit the content.
// This may be overriden by a subclass for testing purposes.
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698