Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2504403004: Mojo C++ bindings: switch the generated code of clipboard.mojom to use STL types. (Closed)

Created:
4 years, 1 month ago by yzshen1
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, tfarina, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: switch the generated code of clipboard.mojom to use STL types. BUG=662515 Committed: https://crrev.com/c50de9461915f2f19a64ee5105ff885134661810 Cr-Commit-Position: refs/heads/master@{#433116}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -93 lines) Patch
M mojo/public/cpp/bindings/array.h View 1 4 chunks +20 lines, -0 lines 2 comments Download
M services/ui/clipboard/clipboard_impl.h View 1 chunk +3 lines, -2 lines 0 comments Download
M services/ui/clipboard/clipboard_impl.cc View 1 5 chunks +14 lines, -15 lines 0 comments Download
M services/ui/clipboard/clipboard_unittest.cc View 1 4 chunks +8 lines, -10 lines 0 comments Download
M services/ui/public/interfaces/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/mus/clipboard_mus.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/views/mus/clipboard_mus.cc View 1 15 chunks +62 lines, -62 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (11 generated)
yzshen1
Hi, Scott. Would you please take a look? Thanks!
4 years, 1 month ago (2016-11-17 21:38:06 UTC) #8
sky
LGTM https://codereview.chromium.org/2504403004/diff/20001/mojo/public/cpp/bindings/array.h File mojo/public/cpp/bindings/array.h (right): https://codereview.chromium.org/2504403004/diff/20001/mojo/public/cpp/bindings/array.h#newcode53 mojo/public/cpp/bindings/array.h:53: Array(const base::Optional<std::vector<T>>& other) Is it typical not to ...
4 years, 1 month ago (2016-11-18 00:41:55 UTC) #9
yzshen1
https://codereview.chromium.org/2504403004/diff/20001/mojo/public/cpp/bindings/array.h File mojo/public/cpp/bindings/array.h (right): https://codereview.chromium.org/2504403004/diff/20001/mojo/public/cpp/bindings/array.h#newcode53 mojo/public/cpp/bindings/array.h:53: Array(const base::Optional<std::vector<T>>& other) On 2016/11/18 00:41:55, sky wrote: > ...
4 years, 1 month ago (2016-11-18 00:48:10 UTC) #10
sky
Fine by me. SLGTM On Thu, Nov 17, 2016 at 4:48 PM, <yzshen@chromium.org> wrote: > ...
4 years, 1 month ago (2016-11-18 00:52:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504403004/20001
4 years, 1 month ago (2016-11-18 02:26:17 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-18 04:52:21 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 04:56:49 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c50de9461915f2f19a64ee5105ff885134661810
Cr-Commit-Position: refs/heads/master@{#433116}

Powered by Google App Engine
This is Rietveld 408576698