Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2505133003: Mojo C++ bindings: switch part of the services/ui/public/interfaces mojom target to use STL types. (Closed)

Created:
4 years, 1 month ago by yzshen1
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: switch part of the services/ui/public/interfaces mojom target to use STL types. BUG=662515 Committed: https://crrev.com/d43ab4273520d09425be09c8348b0ede47dc0381 Cr-Commit-Position: refs/heads/master@{#432815}

Patch Set 1 #

Patch Set 2 : Merge branch 'master' into c139_wrappers_ui #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -23 lines) Patch
M services/ui/public/interfaces/BUILD.gn View 1 3 chunks +26 lines, -4 lines 0 comments Download
M services/ui/ws/user_display_manager.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M services/ui/ws/user_display_manager_unittest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M services/ui/ws/user_id_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/user_id_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/window_server_test_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/window_server_test_impl.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M ui/views/mus/screen_mus.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/mus/screen_mus.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (14 generated)
yzshen1
Hi, Scott. Would you please take a look? Thanks!
4 years, 1 month ago (2016-11-16 23:15:55 UTC) #4
sky
LGTM
4 years, 1 month ago (2016-11-17 00:56:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505133003/20001
4 years, 1 month ago (2016-11-17 00:58:48 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/69302)
4 years, 1 month ago (2016-11-17 01:29:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505133003/20001
4 years, 1 month ago (2016-11-17 07:55:22 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-17 08:38:22 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 08:42:54 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d43ab4273520d09425be09c8348b0ede47dc0381
Cr-Commit-Position: refs/heads/master@{#432815}

Powered by Google App Engine
This is Rietveld 408576698