Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 2504223002: [fullcodegen] Remove deprecated generator implementation. (Closed)

Created:
4 years, 1 month ago by Michael Starzinger
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[fullcodegen] Remove deprecated generator implementation. This removes the deprecated generator support for resumable functions from {FullCodeGenerator}. The existing {AstNumbering} heuristic already triggers Ignition for most resumable functions, with this change we make said heuristic a hard choice and remove the deprecated code. This also has the advantage that any suspended {JSGeneratorObject} instance on the heap is guaranteed to have code based on a bytecode array. R=bmeurer@chromium.org Committed: https://crrev.com/09255541116e651690772f818592d5b6bef6a9d4 Cr-Commit-Position: refs/heads/master@{#41135}

Patch Set 1 #

Patch Set 2 : Another guard. #

Patch Set 3 : Fix ia32 register typo (in-brain register allocation FTW). #

Patch Set 4 : Fix stray comment. #

Patch Set 5 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -977 lines) Patch
M src/bailout-reason.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins/arm/builtins-arm.cc View 1 2 3 2 chunks +8 lines, -50 lines 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 2 chunks +8 lines, -50 lines 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 1 2 3 4 2 chunks +9 lines, -51 lines 0 comments Download
M src/builtins/mips/builtins-mips.cc View 2 chunks +8 lines, -50 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 1 2 3 4 2 chunks +8 lines, -50 lines 0 comments Download
M src/builtins/ppc/builtins-ppc.cc View 2 chunks +7 lines, -57 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 2 chunks +7 lines, -55 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 1 2 3 4 2 chunks +8 lines, -54 lines 0 comments Download
M src/builtins/x87/builtins-x87.cc View 2 chunks +8 lines, -50 lines 0 comments Download
M src/compiler.cc View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M src/frames.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/frames.cc View 1 2 3 4 1 chunk +0 lines, -9 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 2 3 4 1 chunk +2 lines, -50 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 2 3 4 1 chunk +2 lines, -57 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 2 3 4 1 chunk +2 lines, -50 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 3 4 1 chunk +2 lines, -47 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 3 4 1 chunk +2 lines, -47 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 2 3 4 1 chunk +2 lines, -51 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 2 3 4 1 chunk +2 lines, -51 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 2 3 4 1 chunk +2 lines, -51 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 2 3 4 1 chunk +2 lines, -50 lines 0 comments Download
M src/runtime/runtime.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-generator.cc View 1 2 3 4 2 chunks +0 lines, -41 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 31 (25 generated)
Michael Starzinger
I plan to land this after the 5.6 branch has been created. Benedikt: PTAL. Ross: ...
4 years, 1 month ago (2016-11-16 13:30:14 UTC) #6
rmcilroy
Nice! :) LGTM FWIW
4 years, 1 month ago (2016-11-16 13:45:06 UTC) #10
Benedikt Meurer
LGTM!!1!
4 years, 1 month ago (2016-11-16 13:45:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504223002/80001
4 years, 1 month ago (2016-11-21 12:23:15 UTC) #26
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-11-21 12:25:18 UTC) #29
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 12:25:48 UTC) #31
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/09255541116e651690772f818592d5b6bef6a9d4
Cr-Commit-Position: refs/heads/master@{#41135}

Powered by Google App Engine
This is Rietveld 408576698