Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2515253003: [runtime] Ensure {JSGeneratorObject} is created for bytecode. (Closed)

Created:
4 years, 1 month ago by Michael Starzinger
Modified:
4 years, 1 month ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Ensure {JSGeneratorObject} is created for bytecode. This removes some outdated code that allocates a {JSGeneratorObject} for baseline code. We no longer support such a representation of generators and can rely on bytecode being available for all generators. R=neis@chromium.org Committed: https://crrev.com/2405ab11b5899e90fee62b4e1837c65698993fca Cr-Commit-Position: refs/heads/master@{#41137}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M src/runtime/runtime-generator.cc View 1 chunk +5 lines, -11 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
Michael Starzinger
4 years, 1 month ago (2016-11-21 12:05:41 UTC) #1
neis
lgtm. We should probably rename operand_stack to register_file or so at some point.
4 years, 1 month ago (2016-11-21 12:11:26 UTC) #2
Michael Starzinger
On 2016/11/21 12:11:26, neis wrote: > lgtm. > > We should probably rename operand_stack to ...
4 years, 1 month ago (2016-11-21 12:23:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515253003/20001
4 years, 1 month ago (2016-11-21 13:00:04 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-21 13:02:23 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 13:02:39 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2405ab11b5899e90fee62b4e1837c65698993fca
Cr-Commit-Position: refs/heads/master@{#41137}

Powered by Google App Engine
This is Rietveld 408576698