Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: src/compiler.cc

Issue 2504223002: [fullcodegen] Remove deprecated generator implementation. (Closed)
Patch Set: Rebased. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/x87/builtins-x87.cc ('k') | src/compiler/ast-graph-builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index 9c63ca055a330fc56f72cc705eba17ab66d30b21..48a23f971164e8df882ec6cca8670b1e4ebcf9d8 100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -327,6 +327,16 @@ bool UseTurboFan(Handle<SharedFunctionInfo> shared) {
bool ShouldUseIgnition(CompilationInfo* info) {
DCHECK(info->has_shared_info());
+ // Resumable functions are not supported by {FullCodeGenerator}, suspended
+ // activations stored as {JSGeneratorObject} on the heap always assume the
+ // underlying code to be based on the bytecode array.
+ // TODO(mstarzinger): Once we want to deprecate even more support from the
+ // {FullCodeGenerator}, we will compute an appropriate bit in {AstNumbering}
+ // and turn this predicate into a DCHECK instead.
+ if (IsResumableFunction(info->shared_info()->kind())) {
+ return true;
+ }
+
// Skip Ignition for asm.js functions.
if (info->shared_info()->asm_function()) {
return false;
« no previous file with comments | « src/builtins/x87/builtins-x87.cc ('k') | src/compiler/ast-graph-builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698