Refactor StringStream Add methods

Refactor StringStream Add methods

Instead of having functions for 0 to 5 arguments, we now have a
variadic template, allowing for an arbitrary number of arguments.
I also refactored the internal FmtElm class to only include the type
field if building for debug, because it is only used in this setting.

R=titzer@chromium.org, ahaas@chromium.org

Committed: https://crrev.com/a00e1a573334cbd22b3a83e281965c8371836a73
Cr-Commit-Position: refs/heads/master@{#41099}

[Clemens Hammacher, 2016-11-17 16:07:30]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 16:07:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 16:36:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 16:36:14]

Dry run: This issue passed the CQ dry run.

[titzer, 2016-11-17 17:00:38]

https://codereview.chromium.org/2507093004/diff/1/src/string-stream.h
File src/string-stream.h (right):

https://codereview.chromium.org/2507093004/diff/1/src/string-stream.h#newcode60
src/string-stream.h:60: #ifdef DEBUG
Could you do this macro stuff a different way? E.g. just having a macro to
initialize the debug-only {type_} field?

[Clemens Hammacher, 2016-11-17 18:38:29]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 18:38:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2016-11-17 18:40:01]

I also made the FmtElm helper class private to the StringStream.

https://codereview.chromium.org/2507093004/diff/1/src/string-stream.h
File src/string-stream.h (right):

https://codereview.chromium.org/2507093004/diff/1/src/string-stream.h#newcode60
src/string-stream.h:60: #ifdef DEBUG
On 2016/11/17 at 17:00:38, titzer wrote:
> Could you do this macro stuff a different way? E.g. just having a macro to
initialize the debug-only {type_} field?

Did it, and it's much cleaner indeed. Even though more code.

[commit-bot: I haz the power, 2016-11-17 19:11:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 19:11:31]

Dry run: This issue passed the CQ dry run.

[titzer, 2016-11-18 10:40:43]

lgtm

https://codereview.chromium.org/2507093004/diff/20001/src/string-stream.h
File src/string-stream.h (right):

https://codereview.chromium.org/2507093004/diff/20001/src/string-stream.h#new...
src/string-stream.h:88: explicit FmtElm(Type type) : type_(type) {}
Cool, that's a neat trick!

[Clemens Hammacher, 2016-11-18 11:59:03]

The CQ bit was checked by clemensh@chromium.org

[commit-bot: I haz the power, 2016-11-18 11:59:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 12:01:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-18 12:01:46]

Description was changed from

==========
Refactor StringStream Add methods

Instead of having functions for 0 to 5 arguments, we now have a
variadic template, allowing for an arbitrary number of arguments.
I also refactored the internal FmtElm class to only include the type
field if building for debug, because it is only used in this setting.

R=titzer@chromium.org, ahaas@chromium.org
==========

to

==========
Refactor StringStream Add methods

Instead of having functions for 0 to 5 arguments, we now have a
variadic template, allowing for an arbitrary number of arguments.
I also refactored the internal FmtElm class to only include the type
field if building for debug, because it is only used in this setting.

R=titzer@chromium.org, ahaas@chromium.org

Committed: https://crrev.com/a00e1a573334cbd22b3a83e281965c8371836a73
Cr-Commit-Position: refs/heads/master@{#41099}
==========

[commit-bot: I haz the power, 2016-11-18 12:01:47]

Patchset 2 (id:??) landed as
https://crrev.com/a00e1a573334cbd22b3a83e281965c8371836a73
Cr-Commit-Position: refs/heads/master@{#41099}