📰 Fix crash when data changes while items are swiped

[NTP Client] Fix crash when data changes while items are swiped

This is just a hotfix, not sure about the cause of the bug itself.

BUG=664466
Committed: https://crrev.com/2ed576a5180a9ff1c147b77300fd1c7ccaf97dc3
Cr-Commit-Position: refs/heads/master@{#432527}

[dgn, 2016-11-16 15:08:41]

Description was changed from

==========
[NTP Client] Fix crash when data changes while items are swiped

This is just a hotfix, not sure about the cause of the bug itself.

BUG=664466
==========

to

==========
[NTP Client] Fix crash when data changes while items are swiped

This is just a hotfix, not sure about the cause of the bug itself.

BUG=664466
==========

[dgn, 2016-11-16 15:12:33]

dgn@chromium.org changed reviewers:
+ bauerb@chromium.org

[dgn, 2016-11-16 15:12:34]

PTAL

https://codereview.chromium.org/2502993002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java
(right):

https://codereview.chromium.org/2502993002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java:144:
itemView.removeOnAttachStateChangeListener(this);
There is another thing that is wrong with this:

- Press reload
- Start swiping the [Status + Action] pair
- Reload completes
- Status is removed, action stays
- Only a few suggestions are fetched, Action is still visible

Action will still be have a reduced alpha from when they were being swiped. 

That's even less likely to happen than the original bug and fairly benign so I
didn't want to add code to address that yet.

https://codereview.chromium.org/2502993002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
(right):

https://codereview.chromium.org/2502993002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java:391:
if (!mCompensationHeightMap.containsKey(viewHolder)) return;
The actual hotfix is just this line.

[Bernhard Bauer, 2016-11-16 16:06:30]

lgtm

[dgn, 2016-11-16 16:28:03]

The CQ bit was checked by dgn@chromium.org

[commit-bot: I haz the power, 2016-11-16 16:28:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 17:08:21]

Description was changed from

==========
[NTP Client] Fix crash when data changes while items are swiped

This is just a hotfix, not sure about the cause of the bug itself.

BUG=664466
==========

to

==========
[NTP Client] Fix crash when data changes while items are swiped

This is just a hotfix, not sure about the cause of the bug itself.

BUG=664466
==========

[commit-bot: I haz the power, 2016-11-16 17:08:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-16 17:18:16]

Description was changed from

==========
[NTP Client] Fix crash when data changes while items are swiped

This is just a hotfix, not sure about the cause of the bug itself.

BUG=664466
==========

to

==========
[NTP Client] Fix crash when data changes while items are swiped

This is just a hotfix, not sure about the cause of the bug itself.

BUG=664466

Committed: https://crrev.com/2ed576a5180a9ff1c147b77300fd1c7ccaf97dc3
Cr-Commit-Position: refs/heads/master@{#432527}
==========

[commit-bot: I haz the power, 2016-11-16 17:18:16]

Patchset 2 (id:??) landed as
https://crrev.com/2ed576a5180a9ff1c147b77300fd1c7ccaf97dc3
Cr-Commit-Position: refs/heads/master@{#432527}