Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3989)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

Issue 2502993002: 📰 Fix crash when data changes while items are swiped (Closed)
Patch Set: _ Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
index 708c3b82cc23fe4084bd307f610d8fe3c53c0f7d..e867e808b52c6a5d43bacbb818d2a19a684e0538 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
@@ -110,6 +110,9 @@ public void onChildDraw(Canvas c, RecyclerView recyclerView, ViewHolder viewHold
assert viewHolder instanceof NewTabPageViewHolder;
// The item has already been removed. We have nothing more to do.
+ // In some cases a removed children may call this method when unrelated items are
+ // interacted with, but this check also covers the case.
+ // See https://crbug.com/664466, b/32900699
if (viewHolder.getAdapterPosition() == RecyclerView.NO_POSITION) return;
// We use our own implementation of the dismissal animation, so we don't call the

Powered by Google App Engine
This is Rietveld 408576698