chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java - Issue 2502993002: 📰 Fix crash when data changes while items are swiped

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java

Issue 2502993002: 📰 Fix crash when data changes while items are swiped (Closed)

Patch Set: _ Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java

index ef1261d99e1c438c3fe73ab98dff582d0cb0daf7..f8daf4e690e53d2114d6036ea910218dcb370328 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java

@@ -388,7 +388,8 @@ public void onItemDismissStarted(ViewHolder viewHolder) {

/** Called when an item has finished being removed from the view. */

public void onItemDismissFinished(ViewHolder viewHolder) {

- assert mCompensationHeightMap.containsKey(viewHolder);

+ if (!mCompensationHeightMap.containsKey(viewHolder)) return;

dgn 2016/11/16 15:12:34 The actual hotfix is just this line.

mCompensationHeight -= mCompensationHeightMap.remove(viewHolder);

assert mCompensationHeight >= 0;