Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2502663003: CC Animation: Move PropertyAnimationState and TargetProperty to trees. (Closed)

Created:
4 years, 1 month ago by loyso (OOO)
Modified:
4 years, 1 month ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, Eric Willigers, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, rjwright, shans, Ian Vollick
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animation: Move PropertyAnimationState and TargetProperty to trees. CC should not include headers from cc/animation. This is the last CL for moving headers. BUG=575043 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/ab298a03de3710f55f5924263f61c2ca2710edde Cr-Commit-Position: refs/heads/master@{#432292}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -202 lines) Patch
M cc/BUILD.gn View 3 chunks +4 lines, -4 lines 0 comments Download
M cc/animation/animation.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/animation/animation_player.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/animation/element_animations.h View 1 chunk +2 lines, -2 lines 0 comments Download
D cc/animation/property_animation_state.h View 1 chunk +0 lines, -38 lines 0 comments Download
D cc/animation/property_animation_state.cc View 1 chunk +0 lines, -74 lines 0 comments Download
D cc/animation/target_property.h View 1 chunk +0 lines, -34 lines 0 comments Download
D cc/animation/target_property.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M cc/layers/layer.h View 2 chunks +1 line, -1 line 0 comments Download
M cc/layers/layer_impl.h View 2 chunks +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_in_process.h View 2 chunks +1 line, -1 line 0 comments Download
M cc/trees/mutator_host_client.h View 1 chunk +2 lines, -3 lines 0 comments Download
A + cc/trees/property_animation_state.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + cc/trees/property_animation_state.cc View 1 chunk +1 line, -1 line 0 comments Download
A + cc/trees/target_property.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + cc/trees/target_property.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/animation/CompositorTargetProperty.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/layer_animator.h View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 21 (14 generated)
loyso (OOO)
please: aelias@ - cc/ jbroman@ - platform/ piman@ - ui/
4 years, 1 month ago (2016-11-15 02:37:37 UTC) #8
aelias_OOO_until_Jul13
lgtm
4 years, 1 month ago (2016-11-15 02:47:18 UTC) #11
jbroman
platform lgtm
4 years, 1 month ago (2016-11-15 19:07:24 UTC) #15
piman
lgtm
4 years, 1 month ago (2016-11-15 19:32:05 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502663003/1
4 years, 1 month ago (2016-11-15 23:03:20 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 23:43:07 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 23:45:03 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab298a03de3710f55f5924263f61c2ca2710edde
Cr-Commit-Position: refs/heads/master@{#432292}

Powered by Google App Engine
This is Rietveld 408576698