Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2492133002: CC Animation: Move ElementId from animation to trees. (Closed)

Created:
4 years, 1 month ago by loyso (OOO)
Modified:
4 years, 1 month ago
CC:
jbroman, ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animation: Move ElementId from animation to trees. BUG=575043 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/290a27ab670f3ae820448ef43eebab8799c76353 Cr-Commit-Position: refs/heads/master@{#432049}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -144 lines) Patch
M cc/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/animation/animation_events.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/animation/animation_player.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/animation/element_animations.h View 1 chunk +1 line, -1 line 0 comments Download
D cc/animation/element_id.h View 1 1 chunk +0 lines, -70 lines 0 comments Download
D cc/animation/element_id.cc View 1 1 chunk +0 lines, -56 lines 0 comments Download
M cc/blink/web_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer.h View 1 2 chunks +1 line, -1 line 0 comments Download
M cc/layers/layer_impl.h View 2 chunks +1 line, -1 line 0 comments Download
M cc/test/animation_test_common.h View 1 chunk +1 line, -1 line 0 comments Download
A + cc/trees/element_id.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + cc/trees/element_id.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/mutator_host.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/mutator_host_client.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/property_tree.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/scroll_node.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/CompositorElementId.h View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 25 (17 generated)
loyso (OOO)
aelias@, cc/ please! jbroman@, platform/ please.
4 years, 1 month ago (2016-11-11 03:19:37 UTC) #6
aelias_OOO_until_Jul13
lgtm
4 years, 1 month ago (2016-11-11 03:50:15 UTC) #7
jbroman
platform lgtm
4 years, 1 month ago (2016-11-11 15:20:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492133002/1
4 years, 1 month ago (2016-11-14 00:44:04 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/303113) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 1 month ago (2016-11-14 00:46:35 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492133002/20001
4 years, 1 month ago (2016-11-14 23:15:46 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-15 01:47:47 UTC) #23
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 01:52:16 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/290a27ab670f3ae820448ef43eebab8799c76353
Cr-Commit-Position: refs/heads/master@{#432049}

Powered by Google App Engine
This is Rietveld 408576698