Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2489)

Issue 2501883002: DevTools: kill Bindings.NetworkMapping (Closed)

Created:
4 years, 1 month ago by lushnikov
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: kill Bindings.NetworkMapping This patch kills Bindings.NetworkMapping class. Two of its methods were moved under the NetworkProject (since there's no better place for now): - uiSourceCodeForScriptURL - uiSourceCodeForStyleURL BUG=649837 R=dgozman Committed: https://crrev.com/41358950d29405ed01f24cf39489c91bd10e6f93 Cr-Commit-Position: refs/heads/master@{#432559}

Patch Set 1 #

Patch Set 2 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -137 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/navigator-view.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/resource-script-mapping.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js View 1 5 chunks +7 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js View 1 4 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js View 1 2 chunks +3 lines, -6 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js View 1 chunk +0 lines, -78 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js View 1 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js View 1 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/ResourceUtils.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js View 1 5 chunks +5 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/module.json View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/HandlerRegistry.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/Linkifier.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js View 1 3 chunks +2 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 24 (15 generated)
lushnikov
please, take a look
4 years, 1 month ago (2016-11-15 02:21:11 UTC) #3
dgozman
lgtm
4 years, 1 month ago (2016-11-15 02:51:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501883002/20001
4 years, 1 month ago (2016-11-16 03:34:23 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/317971)
4 years, 1 month ago (2016-11-16 04:49:16 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501883002/20001
4 years, 1 month ago (2016-11-16 05:07:06 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/68485)
4 years, 1 month ago (2016-11-16 05:55:14 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501883002/20001
4 years, 1 month ago (2016-11-16 16:22:28 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-16 18:22:42 UTC) #22
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 18:52:28 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/41358950d29405ed01f24cf39489c91bd10e6f93
Cr-Commit-Position: refs/heads/master@{#432559}

Powered by Google App Engine
This is Rietveld 408576698