Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1868)

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js

Issue 2501883002: DevTools: kill Bindings.NetworkMapping (Closed)
Patch Set: rebaseline Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js
diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js b/third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js
index 66bb99f876bd9d44c20e75d9ff92c3f8ca17e6ca..8d703272788f8621c04aca64e15a6b07ac1262a5 100644
--- a/third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js
+++ b/third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js
@@ -9,11 +9,9 @@ Bindings.CSSWorkspaceBinding = class {
/**
* @param {!SDK.TargetManager} targetManager
* @param {!Workspace.Workspace} workspace
- * @param {!Bindings.NetworkMapping} networkMapping
*/
- constructor(targetManager, workspace, networkMapping) {
+ constructor(targetManager, workspace) {
this._workspace = workspace;
- this._networkMapping = networkMapping;
/** @type {!Map.<!SDK.CSSModel, !Bindings.CSSWorkspaceBinding.TargetInfo>} */
this._modelToTargetInfo = new Map();
@@ -28,7 +26,7 @@ Bindings.CSSWorkspaceBinding = class {
var cssModel = SDK.CSSModel.fromTarget(target);
if (cssModel) {
this._modelToTargetInfo.set(
- cssModel, new Bindings.CSSWorkspaceBinding.TargetInfo(cssModel, this._workspace, this._networkMapping));
+ cssModel, new Bindings.CSSWorkspaceBinding.TargetInfo(cssModel, this._workspace));
}
}
@@ -58,7 +56,7 @@ Bindings.CSSWorkspaceBinding = class {
var targetInfo = this._modelToTargetInfo.get(header.cssModel());
if (!targetInfo) {
targetInfo =
- new Bindings.CSSWorkspaceBinding.TargetInfo(header.cssModel(), this._workspace, this._networkMapping);
+ new Bindings.CSSWorkspaceBinding.TargetInfo(header.cssModel(), this._workspace);
this._modelToTargetInfo.set(header.cssModel(), targetInfo);
}
return targetInfo;
@@ -149,13 +147,12 @@ Bindings.CSSWorkspaceBinding.TargetInfo = class {
/**
* @param {!SDK.CSSModel} cssModel
* @param {!Workspace.Workspace} workspace
- * @param {!Bindings.NetworkMapping} networkMapping
*/
- constructor(cssModel, workspace, networkMapping) {
+ constructor(cssModel, workspace) {
this._cssModel = cssModel;
- this._stylesSourceMapping = new Bindings.StylesSourceMapping(cssModel, workspace, networkMapping);
+ this._stylesSourceMapping = new Bindings.StylesSourceMapping(cssModel, workspace);
this._sassSourceMapping =
- new Bindings.SASSSourceMapping(cssModel, networkMapping, Bindings.NetworkProject.forTarget(cssModel.target()));
+ new Bindings.SASSSourceMapping(cssModel, workspace, Bindings.NetworkProject.forTarget(cssModel.target()));
/** @type {!Multimap<!SDK.CSSStyleSheetHeader, !Bindings.LiveLocation>} */
this._locations = new Multimap();
@@ -276,7 +273,7 @@ Bindings.CSSWorkspaceBinding.LiveLocation = class extends Bindings.LiveLocationW
var targetInfo = this._binding._targetInfo(this._header);
return targetInfo._rawLocationToUILocation(this._header, cssLocation.lineNumber, cssLocation.columnNumber);
}
- var uiSourceCode = this._binding._networkMapping.uiSourceCodeForStyleURL(cssLocation.url, cssLocation.header());
+ var uiSourceCode = Bindings.NetworkProject.uiSourceCodeForStyleURL(this._binding._workspace, cssLocation.url, cssLocation.header());
if (!uiSourceCode)
return null;
return uiSourceCode.uiLocation(cssLocation.lineNumber, cssLocation.columnNumber);

Powered by Google App Engine
This is Rietveld 408576698