Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js

Issue 2501883002: DevTools: kill Bindings.NetworkMapping (Closed)
Patch Set: rebaseline Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js
diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js b/third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js
index 333c87acb210954f133117e995ae1edfe7d081c0..b154e819b67e1757fb9796776662991bd2cf2603 100644
--- a/third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js
+++ b/third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js
@@ -34,13 +34,13 @@
Bindings.SASSSourceMapping = class {
/**
* @param {!SDK.CSSModel} cssModel
- * @param {!Bindings.NetworkMapping} networkMapping
+ * @param {!Workspace.Workspace} workspace
* @param {!Bindings.NetworkProject} networkProject
*/
- constructor(cssModel, networkMapping, networkProject) {
+ constructor(cssModel, workspace, networkProject) {
this._cssModel = cssModel;
this._networkProject = networkProject;
- this._networkMapping = networkMapping;
+ this._workspace = workspace;
this._eventListeners = [
this._cssModel.addEventListener(SDK.CSSModel.Events.SourceMapAttached, this._sourceMapAttached, this),
this._cssModel.addEventListener(SDK.CSSModel.Events.SourceMapDetached, this._sourceMapDetached, this),
@@ -83,7 +83,7 @@ Bindings.SASSSourceMapping = class {
for (var header of headers) {
Bindings.cssWorkspaceBinding.updateLocations(header);
for (var sourceURL of newSources.keys()) {
- var uiSourceCode = this._networkMapping.uiSourceCodeForStyleURL(sourceURL, header);
+ var uiSourceCode = Bindings.NetworkProject.uiSourceCodeForStyleURL(this._workspace, sourceURL, header);
if (!uiSourceCode) {
console.error('Failed to update source for ' + sourceURL);
continue;
@@ -108,7 +108,7 @@ Bindings.SASSSourceMapping = class {
var entry = sourceMap.findEntry(rawLocation.lineNumber, rawLocation.columnNumber);
if (!entry || !entry.sourceURL)
return null;
- var uiSourceCode = this._networkMapping.uiSourceCodeForStyleURL(entry.sourceURL, rawLocation.header());
+ var uiSourceCode = Bindings.NetworkProject.uiSourceCodeForStyleURL(this._workspace, entry.sourceURL, rawLocation.header());
if (!uiSourceCode)
return null;
return uiSourceCode.uiLocation(entry.sourceLineNumber || 0, entry.sourceColumnNumber);

Powered by Google App Engine
This is Rietveld 408576698