Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2501743002: Cleaning methods and visibility in cfwl_* files. (Closed)

Created:
4 years, 1 month ago by dsinclair
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez, npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Cleaning methods and visibility in cfwl_* files. First pass at cleaning up visibility, return values and const'ness of cfwl_* class. Committed: https://pdfium.googlesource.com/pdfium/+/05b9a317d66c29f740e4b0e89ea87143a11d61fc

Patch Set 1 #

Total comments: 8

Patch Set 2 : Review feedback #

Total comments: 6

Patch Set 3 : review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -261 lines) Patch
M xfa/fwl/core/cfwl_widgetmgr.h View 1 2 3 chunks +57 lines, -53 lines 0 comments Download
M xfa/fwl/core/cfwl_widgetmgr.cpp View 27 chunks +81 lines, -187 lines 0 comments Download
M xfa/fwl/core/fwl_noteimp.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/core/ifwl_widget.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_widget.cpp View 1 chunk +10 lines, -7 lines 0 comments Download
M xfa/fxfa/app/xfa_ffapp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_fwladapter.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_fwladapter.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M xfa/fxfa/xfa_ffapp.h View 4 chunks +4 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (7 generated)
dsinclair
PTAL. https://codereview.chromium.org/2501743002/diff/1/xfa/fwl/core/cfwl_widgetmgr.cpp File xfa/fwl/core/cfwl_widgetmgr.cpp (left): https://codereview.chromium.org/2501743002/diff/1/xfa/fwl/core/cfwl_widgetmgr.cpp#oldcode417 xfa/fwl/core/cfwl_widgetmgr.cpp:417: IFWL_Widget* CFWL_WidgetMgr::GetSiblingRadioButton(IFWL_Widget* pWidget, Always nullptr, which caused a ...
4 years, 1 month ago (2016-11-14 22:08:41 UTC) #2
Tom Sepez
https://codereview.chromium.org/2501743002/diff/1/xfa/fwl/core/cfwl_widgetmgr.h File xfa/fwl/core/cfwl_widgetmgr.h (right): https://codereview.chromium.org/2501743002/diff/1/xfa/fwl/core/cfwl_widgetmgr.h#newcode47 xfa/fwl/core/cfwl_widgetmgr.h:47: class IFWL_WidgetMgrDelegate { I'd expect this to be in ...
4 years, 1 month ago (2016-11-14 23:03:04 UTC) #7
dsinclair
https://codereview.chromium.org/2501743002/diff/1/xfa/fwl/core/cfwl_widgetmgr.h File xfa/fwl/core/cfwl_widgetmgr.h (right): https://codereview.chromium.org/2501743002/diff/1/xfa/fwl/core/cfwl_widgetmgr.h#newcode47 xfa/fwl/core/cfwl_widgetmgr.h:47: class IFWL_WidgetMgrDelegate { On 2016/11/14 23:03:04, Tom Sepez wrote: ...
4 years, 1 month ago (2016-11-14 23:10:27 UTC) #8
npm
https://codereview.chromium.org/2501743002/diff/1/xfa/fwl/core/cfwl_widgetmgr.h File xfa/fwl/core/cfwl_widgetmgr.h (right): https://codereview.chromium.org/2501743002/diff/1/xfa/fwl/core/cfwl_widgetmgr.h#newcode47 xfa/fwl/core/cfwl_widgetmgr.h:47: class IFWL_WidgetMgrDelegate { On 2016/11/14 23:10:26, dsinclair wrote: > ...
4 years, 1 month ago (2016-11-15 18:20:19 UTC) #9
Tom Sepez
https://codereview.chromium.org/2501743002/diff/1/xfa/fwl/core/cfwl_widgetmgr.h File xfa/fwl/core/cfwl_widgetmgr.h (right): https://codereview.chromium.org/2501743002/diff/1/xfa/fwl/core/cfwl_widgetmgr.h#newcode47 xfa/fwl/core/cfwl_widgetmgr.h:47: class IFWL_WidgetMgrDelegate { Also, who calls the delegate methods? ...
4 years, 1 month ago (2016-11-15 18:27:22 UTC) #10
dsinclair
https://codereview.chromium.org/2501743002/diff/1/xfa/fwl/core/cfwl_widgetmgr.h File xfa/fwl/core/cfwl_widgetmgr.h (right): https://codereview.chromium.org/2501743002/diff/1/xfa/fwl/core/cfwl_widgetmgr.h#newcode47 xfa/fwl/core/cfwl_widgetmgr.h:47: class IFWL_WidgetMgrDelegate { On 2016/11/15 18:27:21, Tom Sepez wrote: ...
4 years, 1 month ago (2016-11-15 18:40:36 UTC) #11
dsinclair
https://codereview.chromium.org/2501743002/diff/20001/xfa/fwl/core/cfwl_widgetmgr.h File xfa/fwl/core/cfwl_widgetmgr.h (right): https://codereview.chromium.org/2501743002/diff/20001/xfa/fwl/core/cfwl_widgetmgr.h#newcode26 xfa/fwl/core/cfwl_widgetmgr.h:26: class IFWL_WidgetMgrDelegate; On 2016/11/15 18:20:19, npm wrote: > Is ...
4 years, 1 month ago (2016-11-15 19:05:16 UTC) #12
npm
lgtm
4 years, 1 month ago (2016-11-15 19:40:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501743002/40001
4 years, 1 month ago (2016-11-15 19:42:07 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 20:00:44 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/05b9a317d66c29f740e4b0e89ea87143a11d...

Powered by Google App Engine
This is Rietveld 408576698