Cleanup cfwl_* files.

Cleanup cfwl_* files.

This Cl cleans up the visibility, method usage and return values in the
remaining CFWL files.

Committed: https://pdfium.googlesource.com/pdfium/+/38eaf4b11383e24a00192132b683cc07e38622a6

[dsinclair, 2016-11-14 23:57:34]

dsinclair@chromium.org changed reviewers:
+ npm@chromium.org, tsepez@chromium.org

[dsinclair, 2016-11-14 23:57:34]

PTAL.

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_datetimep...
File xfa/fwl/core/cfwl_datetimepicker.cpp (right):

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_datetimep...
xfa/fwl/core/cfwl_datetimepicker.cpp:69: iYear = 2011;
The ifwl file defaults these to 2010-03-29 ....

[dsinclair, 2016-11-14 23:57:37]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 23:57:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 01:20:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 01:20:19]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-11-15 18:44:59]

lgtm

https://codereview.chromium.org/2498163002/diff/1/xfa/fde/cfde_txtedtengine.cpp
File xfa/fde/cfde_txtedtengine.cpp (right):

https://codereview.chromium.org/2498163002/diff/1/xfa/fde/cfde_txtedtengine.c...
xfa/fde/cfde_txtedtengine.cpp:165: if (nCount == -1) {
nit: {} not needed.

https://codereview.chromium.org/2498163002/diff/1/xfa/fde/cfde_txtedtengine.h
File xfa/fde/cfde_txtedtengine.h (right):

https://codereview.chromium.org/2498163002/diff/1/xfa/fde/cfde_txtedtengine.h...
xfa/fde/cfde_txtedtengine.h:34: void GetText(CFX_WideString& wsText,
if wsText is an out parameter, its cleaner to return it instead of void.

https://codereview.chromium.org/2498163002/diff/1/xfa/fde/cfde_txtedtengine.h...
xfa/fde/cfde_txtedtengine.h:63: int32_t GetSelRange(int32_t nIndex, int32_t&
nStart) const;
Can this return a FDE_TXTEDITSELRANGE instead of one scalar value and an out
param?  Ick.

https://codereview.chromium.org/2498163002/diff/1/xfa/fde/cfde_txtedtengine.h...
xfa/fde/cfde_txtedtengine.h:131: void RecoverParagEnd(CFX_WideString& wsText)
const;
ditto

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_barcode.h
File xfa/fwl/core/cfwl_barcode.h (right):

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_barcode.h...
xfa/fwl/core/cfwl_barcode.h:16: explicit CFWL_Barcode(const IFWL_App*);
nit: (const IFWL_App* pApp);

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_checkbox.h
File xfa/fwl/core/cfwl_checkbox.h (right):

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_checkbox....
xfa/fwl/core/cfwl_checkbox.h:15: explicit CFWL_CheckBox(const IFWL_App*);
nitto

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_combobox.h
File xfa/fwl/core/cfwl_combobox.h (right):

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_combobox....
xfa/fwl/core/cfwl_combobox.h:18: explicit CFWL_ComboBox(const IFWL_App*);
ditto nit

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_datetimep...
File xfa/fwl/core/cfwl_datetimepicker.cpp (right):

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_datetimep...
xfa/fwl/core/cfwl_datetimepicker.cpp:69: iYear = 2011;
On 2016/11/14 23:57:34, dsinclair wrote:
> The ifwl file defaults these to 2010-03-29 ....

this doesn't seem very useful.

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_datetimep...
File xfa/fwl/core/cfwl_datetimepicker.h (right):

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_datetimep...
xfa/fwl/core/cfwl_datetimepicker.h:15: explicit CFWL_DateTimePicker(const
IFWL_App*);
"

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_edit.h
File xfa/fwl/core/cfwl_edit.h (right):

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_edit.h#ne...
xfa/fwl/core/cfwl_edit.h:30: int32_t GetSelRange(int32_t nIndex, int32_t&
nStart) const;
return range struct instead?

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_listbox.h
File xfa/fwl/core/cfwl_listbox.h (right):

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_listbox.h...
xfa/fwl/core/cfwl_listbox.h:20: explicit CFWL_ListBox(const IFWL_App*);
""

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_picturebox.h
File xfa/fwl/core/cfwl_picturebox.h (right):

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_picturebo...
xfa/fwl/core/cfwl_picturebox.h:15: explicit CFWL_PictureBox(const IFWL_App*);
ditto

[dsinclair, 2016-11-15 19:10:23]

https://codereview.chromium.org/2498163002/diff/1/xfa/fde/cfde_txtedtengine.cpp
File xfa/fde/cfde_txtedtengine.cpp (right):

https://codereview.chromium.org/2498163002/diff/1/xfa/fde/cfde_txtedtengine.c...
xfa/fde/cfde_txtedtengine.cpp:165: if (nCount == -1) {
On 2016/11/15 18:44:59, Tom Sepez wrote:
> nit: {} not needed.

Done.

https://codereview.chromium.org/2498163002/diff/1/xfa/fde/cfde_txtedtengine.h
File xfa/fde/cfde_txtedtengine.h (right):

https://codereview.chromium.org/2498163002/diff/1/xfa/fde/cfde_txtedtengine.h...
xfa/fde/cfde_txtedtengine.h:34: void GetText(CFX_WideString& wsText,
On 2016/11/15 18:44:59, Tom Sepez wrote:
> if wsText is an out parameter, its cleaner to return it instead of void.


Follow up. There are a lot of methods that take out params when they should just
return. I'm going to tackle them in a later Cl.

https://codereview.chromium.org/2498163002/diff/1/xfa/fde/cfde_txtedtengine.h...
xfa/fde/cfde_txtedtengine.h:63: int32_t GetSelRange(int32_t nIndex, int32_t&
nStart) const;
On 2016/11/15 18:44:59, Tom Sepez wrote:
> Can this return a FDE_TXTEDITSELRANGE instead of one scalar value and an out
> param?  Ick.

Acknowledged.

https://codereview.chromium.org/2498163002/diff/1/xfa/fde/cfde_txtedtengine.h...
xfa/fde/cfde_txtedtengine.h:131: void RecoverParagEnd(CFX_WideString& wsText)
const;
On 2016/11/15 18:44:59, Tom Sepez wrote:
> ditto

Acknowledged.

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_barcode.h
File xfa/fwl/core/cfwl_barcode.h (right):

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_barcode.h...
xfa/fwl/core/cfwl_barcode.h:16: explicit CFWL_Barcode(const IFWL_App*);
On 2016/11/15 18:44:59, Tom Sepez wrote:
> nit: (const IFWL_App* pApp);

Done.

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_checkbox.h
File xfa/fwl/core/cfwl_checkbox.h (right):

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_checkbox....
xfa/fwl/core/cfwl_checkbox.h:15: explicit CFWL_CheckBox(const IFWL_App*);
On 2016/11/15 18:44:59, Tom Sepez wrote:
> nitto

Done.

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_combobox.h
File xfa/fwl/core/cfwl_combobox.h (right):

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_combobox....
xfa/fwl/core/cfwl_combobox.h:18: explicit CFWL_ComboBox(const IFWL_App*);
On 2016/11/15 18:44:59, Tom Sepez wrote:
> ditto nit

Done.

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_datetimep...
File xfa/fwl/core/cfwl_datetimepicker.cpp (right):

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_datetimep...
xfa/fwl/core/cfwl_datetimepicker.cpp:69: iYear = 2011;
On 2016/11/15 18:44:59, Tom Sepez wrote:
> On 2016/11/14 23:57:34, dsinclair wrote:
> > The ifwl file defaults these to 2010-03-29 ....
> 
> this doesn't seem very useful.


Nope, but I don't know what else to do with it, so leaving as is ....

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_datetimep...
File xfa/fwl/core/cfwl_datetimepicker.h (right):

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_datetimep...
xfa/fwl/core/cfwl_datetimepicker.h:15: explicit CFWL_DateTimePicker(const
IFWL_App*);
On 2016/11/15 18:44:59, Tom Sepez wrote:
> "

Done.

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_edit.h
File xfa/fwl/core/cfwl_edit.h (right):

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_edit.h#ne...
xfa/fwl/core/cfwl_edit.h:30: int32_t GetSelRange(int32_t nIndex, int32_t&
nStart) const;
On 2016/11/15 18:44:59, Tom Sepez wrote:
> return range struct instead?

Acknowledged.

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_listbox.h
File xfa/fwl/core/cfwl_listbox.h (right):

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_listbox.h...
xfa/fwl/core/cfwl_listbox.h:20: explicit CFWL_ListBox(const IFWL_App*);
On 2016/11/15 18:44:59, Tom Sepez wrote:
> ""

Done.

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_picturebox.h
File xfa/fwl/core/cfwl_picturebox.h (right):

https://codereview.chromium.org/2498163002/diff/1/xfa/fwl/core/cfwl_picturebo...
xfa/fwl/core/cfwl_picturebox.h:15: explicit CFWL_PictureBox(const IFWL_App*);
On 2016/11/15 18:44:59, Tom Sepez wrote:
> ditto

Done.

[dsinclair, 2016-11-15 20:16:02]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-11-15 20:16:02]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2498163002/#ps20001
(title: "Review feedback")

[commit-bot: I haz the power, 2016-11-15 20:16:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 20:33:09]

Description was changed from

==========
Cleanup cfwl_* files.

This Cl cleans up the visibility, method usage and return values in the
remaining CFWL files.
==========

to

==========
Cleanup cfwl_* files.

This Cl cleans up the visibility, method usage and return values in the
remaining CFWL files.

Committed:
https://pdfium.googlesource.com/pdfium/+/38eaf4b11383e24a00192132b683cc07e386...
==========

[commit-bot: I haz the power, 2016-11-15 20:33:10]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/38eaf4b11383e24a00192132b683cc07e386...