Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: xfa/fwl/core/fwl_noteimp.cpp

Issue 2501743002: Cleaning methods and visibility in cfwl_* files. (Closed)
Patch Set: review feedback Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « xfa/fwl/core/cfwl_widgetmgr.cpp ('k') | xfa/fwl/core/ifwl_widget.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "xfa/fwl/core/fwl_noteimp.h" 7 #include "xfa/fwl/core/fwl_noteimp.h"
8 8
9 #include "core/fxcrt/fx_ext.h" 9 #include "core/fxcrt/fx_ext.h"
10 #include "third_party/base/ptr_util.h" 10 #include "third_party/base/ptr_util.h"
(...skipping 368 matching lines...) Expand 10 before | Expand all | Expand 10 after
379 if (pMsg->m_dwCmd == FWL_KeyCommand::KeyDown && 379 if (pMsg->m_dwCmd == FWL_KeyCommand::KeyDown &&
380 pMsg->m_dwKeyCode == FWL_VKEY_Tab) { 380 pMsg->m_dwKeyCode == FWL_VKEY_Tab) {
381 CFWL_WidgetMgr* pWidgetMgr = pMessageForm->GetOwnerApp()->GetWidgetMgr(); 381 CFWL_WidgetMgr* pWidgetMgr = pMessageForm->GetOwnerApp()->GetWidgetMgr();
382 IFWL_Widget* pForm = GetMessageForm(pMsg->m_pDstTarget); 382 IFWL_Widget* pForm = GetMessageForm(pMsg->m_pDstTarget);
383 IFWL_Widget* pFocus = m_pFocus; 383 IFWL_Widget* pFocus = m_pFocus;
384 if (m_pFocus) { 384 if (m_pFocus) {
385 if (pWidgetMgr->GetSystemFormWidget(m_pFocus) != pForm) 385 if (pWidgetMgr->GetSystemFormWidget(m_pFocus) != pForm)
386 pFocus = nullptr; 386 pFocus = nullptr;
387 } 387 }
388 bool bFind = false; 388 bool bFind = false;
389 IFWL_Widget* pNextTabStop = pWidgetMgr->nextTab(pForm, pFocus, bFind); 389 IFWL_Widget* pNextTabStop = pWidgetMgr->NextTab(pForm, pFocus, bFind);
390 if (!pNextTabStop) { 390 if (!pNextTabStop) {
391 bFind = false; 391 bFind = false;
392 pNextTabStop = pWidgetMgr->nextTab(pForm, nullptr, bFind); 392 pNextTabStop = pWidgetMgr->NextTab(pForm, nullptr, bFind);
393 } 393 }
394 if (pNextTabStop == pFocus) { 394 if (pNextTabStop == pFocus) {
395 return true; 395 return true;
396 } 396 }
397 if (pNextTabStop) { 397 if (pNextTabStop) {
398 SetFocus(pNextTabStop); 398 SetFocus(pNextTabStop);
399 } 399 }
400 return true; 400 return true;
401 } 401 }
402 #endif 402 #endif
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
622 case CFWL_EventType::Close: 622 case CFWL_EventType::Close:
623 return !!(dwFilter & FWL_EVENT_CLOSE_MASK); 623 return !!(dwFilter & FWL_EVENT_CLOSE_MASK);
624 case CFWL_EventType::SizeChanged: 624 case CFWL_EventType::SizeChanged:
625 return !!(dwFilter & FWL_EVENT_SIZECHANGED_MASK); 625 return !!(dwFilter & FWL_EVENT_SIZECHANGED_MASK);
626 case CFWL_EventType::Idle: 626 case CFWL_EventType::Idle:
627 return !!(dwFilter & FWL_EVENT_IDLE_MASK); 627 return !!(dwFilter & FWL_EVENT_IDLE_MASK);
628 default: 628 default:
629 return !!(dwFilter & FWL_EVENT_CONTROL_MASK); 629 return !!(dwFilter & FWL_EVENT_CONTROL_MASK);
630 } 630 }
631 } 631 }
OLDNEW
« no previous file with comments | « xfa/fwl/core/cfwl_widgetmgr.cpp ('k') | xfa/fwl/core/ifwl_widget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698