Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2501343004: Exclude all references into the VM isolate in heap snapshots. (Closed)

Created:
4 years, 1 month ago by rmacnak
Modified:
4 years, 1 month ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Exclude all references into the VM isolate in heap snapshots. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/f5b1f158c00d99311df62ba718df94cad4d9e60e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M runtime/observatory/lib/object_graph.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/object_graph.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 1 month ago (2016-11-15 18:56:20 UTC) #2
Cutch
lgtm
4 years, 1 month ago (2016-11-15 18:57:59 UTC) #3
rmacnak
4 years, 1 month ago (2016-11-15 19:03:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f5b1f158c00d99311df62ba718df94cad4d9e60e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698