Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Unified Diff: runtime/vm/object_graph.cc

Issue 2501343004: Exclude all references into the VM isolate in heap snapshots. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/object_graph.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object_graph.cc
diff --git a/runtime/vm/object_graph.cc b/runtime/vm/object_graph.cc
index 66bbaca88ac09e5712b301fd9aa1b7064fabef2b..c80c80c4f3e33e9b9c2c02b8b078a0718e42c728 100644
--- a/runtime/vm/object_graph.cc
+++ b/runtime/vm/object_graph.cc
@@ -491,13 +491,14 @@ class WritePointerVisitor : public ObjectPointerVisitor {
: ObjectPointerVisitor(isolate), stream_(stream), count_(0) {}
virtual void VisitPointers(RawObject** first, RawObject** last) {
for (RawObject** current = first; current <= last; ++current) {
- if (!(*current)->IsHeapObject() || (*current == Object::null())) {
- // Ignore smis and nulls for now.
+ RawObject* object = *current;
+ if (!object->IsHeapObject() || object->IsVMHeapObject()) {
+ // Ignore smis and objects in the VM isolate for now.
// TODO(koda): To track which field each pointer corresponds to,
// we'll need to encode which fields were omitted here.
continue;
}
- WritePtr(*current, stream_);
+ WritePtr(object, stream_);
++count_;
}
}
« no previous file with comments | « runtime/observatory/lib/object_graph.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698