Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Unified Diff: runtime/observatory/lib/object_graph.dart

Issue 2501343004: Exclude all references into the VM isolate in heap snapshots. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/object_graph.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/object_graph.dart
diff --git a/runtime/observatory/lib/object_graph.dart b/runtime/observatory/lib/object_graph.dart
index f070165ecf54f18ba043b122d5bc1a534dc2c332..d1c171bfe017a6ceb8118ba67054e412d412b80c 100644
--- a/runtime/observatory/lib/object_graph.dart
+++ b/runtime/observatory/lib/object_graph.dart
@@ -594,7 +594,8 @@ class ObjectGraph {
succs[edge] = childId;
edge++;
} else {
- // Reference into VM isolate's heap.
+ throw new Exception(
+ "Heap snapshot contains an edge but lacks its target node");
}
stream.readUnsigned();
}
@@ -603,8 +604,7 @@ class ObjectGraph {
firstSuccs[id] = edge; // Extra entry for cheap boundary detection.
assert(id == N + 1);
- assert(edge <= E); // edge is smaller because E was computed before we knew
- // if references pointed into the VM isolate
+ assert(edge == E);
_E = edge;
_firstSuccs = firstSuccs;
« no previous file with comments | « no previous file | runtime/vm/object_graph.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698