Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1102)

Unified Diff: content/browser/devtools/protocol/io_handler.h

Issue 2500093002: [DevTools] Move IO and Tracing to new generator. (Closed)
Patch Set: roll Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/io_handler.h
diff --git a/content/browser/devtools/protocol/io_handler.h b/content/browser/devtools/protocol/io_handler.h
index e952bd0637271bcea280406edf8b8e86bf9dc2c5..647a270c6c1ba041e2a5f72695478f8bf31cf050 100644
--- a/content/browser/devtools/protocol/io_handler.h
+++ b/content/browser/devtools/protocol/io_handler.h
@@ -7,45 +7,45 @@
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
-#include "content/browser/devtools/protocol/devtools_protocol_dispatcher.h"
+#include "content/browser/devtools/protocol/io.h"
namespace base {
class RefCountedString;
}
namespace content {
-namespace devtools {
class DevToolsIOContext;
-namespace io {
+namespace protocol {
-class IOHandler {
+class IOHandler : public IO::Backend {
public:
- using Response = DevToolsProtocolClient::Response;
-
explicit IOHandler(DevToolsIOContext* io_context);
- ~IOHandler();
+ ~IOHandler() override;
- void SetClient(std::unique_ptr<Client> client);
+ void Wire(UberDispatcher*);
+ Response Disable() override;
// Protocol methods.
- Response Read(DevToolsCommandId command_id, const std::string& handle,
- const int* offset, const int* max_size);
- Response Close(const std::string& handle);
+ void Read(
+ const std::string& handle,
+ Maybe<int> offset,
+ Maybe<int> max_size,
+ std::unique_ptr<ReadCallback> callback) override;
+ Response Close(const std::string& handle) override;
private:
- void ReadComplete(DevToolsCommandId command_id,
+ void ReadComplete(std::unique_ptr<ReadCallback> callback,
const scoped_refptr<base::RefCountedString>& data, int status);
- std::unique_ptr<Client> client_;
+ std::unique_ptr<IO::Frontend> frontend_;
DevToolsIOContext* io_context_;
base::WeakPtrFactory<IOHandler> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(IOHandler);
};
-} // namespace io
-} // namespace devtools
+} // namespace protocol
} // namespace content
#endif // CONTENT_BROWSER_DEVTOOLS_PROTOCOL_TRACING_HANDLER_H_

Powered by Google App Engine
This is Rietveld 408576698