[DevTools] Move IO and Tracing to new generator.

content/browser/devtools/devtools_protocol_handler.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/devtools/devtools_protocol_handler.h"
 
 #include <utility>
 
 #include "base/bind.h"
-#include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
+#include "base/values.h"
 #include "base/memory/ptr_util.h"
 #include "content/browser/devtools/devtools_agent_host_impl.h"
 #include "content/browser/devtools/devtools_manager.h"
 #include "content/public/browser/devtools_manager_delegate.h"
 
 namespace content {
 
 namespace {
 
 const char kIdParam[] = "id";
@@ skipping 18 matching lines @@
 
 }  // namespace
 
 DevToolsProtocolHandler::DevToolsProtocolHandler(
     DevToolsAgentHostImpl* agent_host)
     : agent_host_(agent_host), client_(agent_host), dispatcher_(agent_host) {}
 
 DevToolsProtocolHandler::~DevToolsProtocolHandler() {
 }
 
-void DevToolsProtocolHandler::HandleMessage(int session_id,
-                                            const std::string& message) {
+void DevToolsProtocolHandler::HandleMessage(
+    int session_id,
+    std::unique_ptr<base::Value> message) {
   std::unique_ptr<base::DictionaryValue> command =
-      ParseCommand(session_id, message);
+      ParseCommand(session_id, std::move(message));
   if (!command)
     return;
   if (PassCommandToDelegate(session_id, command.get()))
     return;
   HandleCommand(session_id, std::move(command));
 }
 
-bool DevToolsProtocolHandler::HandleOptionalMessage(int session_id,
-                                                    const std::string& message,
-                                                    int* call_id,
-                                                    std::string* method) {
+bool DevToolsProtocolHandler::HandleOptionalMessage(
+    int session_id,
+    std::unique_ptr<base::Value> message,
+    int* call_id,
+    std::string* method) {
   std::unique_ptr<base::DictionaryValue> command =
-      ParseCommand(session_id, message);
+      ParseCommand(session_id, std::move(message));
   if (!command)
     return true;
   if (PassCommandToDelegate(session_id, command.get()))
     return true;
   return HandleOptionalCommand(session_id, std::move(command), call_id, method);

[caseq, 2016/11/15 18:33:59]

nit: you can now extract method right here.

 }
 
 bool DevToolsProtocolHandler::PassCommandToDelegate(
     int session_id,
     base::DictionaryValue* command) {
   DevToolsManagerDelegate* delegate =
       DevToolsManager::GetInstance()->delegate();
   if (!delegate)
     return false;
 
   std::unique_ptr<base::DictionaryValue> response(
       delegate->HandleCommand(agent_host_, command));
   if (response) {
     client_.SendMessage(session_id, *response);
     return true;
   }
 
   return false;
 }
 
 std::unique_ptr<base::DictionaryValue> DevToolsProtocolHandler::ParseCommand(
     int session_id,
-    const std::string& message) {
-  std::unique_ptr<base::Value> value = base::JSONReader::Read(message);
+    std::unique_ptr<base::Value> value) {
   if (!value || !value->IsType(base::Value::TYPE_DICTIONARY)) {
     client_.SendError(
         DevToolsCommandId(DevToolsCommandId::kNoId, session_id),
         Response(kStatusParseError, "Message must be in JSON format"));
     return nullptr;
   }
 
   std::unique_ptr<base::DictionaryValue> command =
       base::WrapUnique(static_cast<base::DictionaryValue*>(value.release()));
   int call_id = DevToolsCommandId::kNoId;
@@ skipping 49 matching lines @@
   DevToolsProtocolDispatcher::CommandHandler command_handler(
       dispatcher_.FindCommandHandler(*method));
   if (!command_handler.is_null()) {
     return command_handler.Run(DevToolsCommandId(*call_id, session_id),
                                TakeDictionary(command.get(), kParamsParam));
   }
   return false;
 }
 
 }  // namespace content