Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java

Issue 2499733002: Remove cached dp viewports in LayoutManager (Closed)
Patch Set: use Float.compare Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java
index 1bce93c8cc1ec46c3f19a6e3f07496511bcd2e09..f7b759fab52bd490cfa36e99f8ea7c80ed4c2731 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java
@@ -6,7 +6,6 @@ package org.chromium.chrome.browser.compositor.layouts;
import android.annotation.TargetApi;
import android.content.Context;
-import android.graphics.RectF;
import android.os.Build;
import android.util.SparseArray;
import android.view.MotionEvent;
@@ -186,11 +185,11 @@ public class LayoutManagerDocument extends LayoutManager
}
@Override
- protected void onViewportChanged(RectF viewportDp) {
- super.onViewportChanged(viewportDp);
+ protected void onViewportChanged() {
+ super.onViewportChanged();
for (int i = 0; i < mTabCache.size(); i++) {
// This assumes that the content width/height is always the size of the host.
- mTabCache.valueAt(i).setContentSize(viewportDp.width(), viewportDp.height());
+ mTabCache.valueAt(i).setContentSize(mHost.getWidth(), mHost.getHeight());
}
}
@@ -282,11 +281,11 @@ public class LayoutManagerDocument extends LayoutManager
boolean isTitleNeeded, float maxContentWidth, float maxContentHeight) {
LayoutTab tab = mTabCache.get(id);
if (tab == null) {
- tab = new LayoutTab(id, incognito, mLastContentWidthDp, mLastContentHeightDp,
+ tab = new LayoutTab(id, incognito, mHost.getWidth(), mHost.getHeight(),
showCloseButton, isTitleNeeded);
mTabCache.put(id, tab);
} else {
- tab.init(mLastContentWidthDp, mLastContentHeightDp, showCloseButton, isTitleNeeded);
+ tab.init(mHost.getWidth(), mHost.getHeight(), showCloseButton, isTitleNeeded);
}
if (maxContentWidth > 0.f) tab.setMaxContentWidth(maxContentWidth);
if (maxContentHeight > 0.f) tab.setMaxContentHeight(maxContentHeight);

Powered by Google App Engine
This is Rietveld 408576698