Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1518)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutProvider.java

Issue 2499733002: Remove cached dp viewports in LayoutManager (Closed)
Patch Set: use Float.compare Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutProvider.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutProvider.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutProvider.java
index 9a20a12d0a0ba348388200f6b2e1c1a2561c5a06..c474de96c635987465c26cbed48b251241e6046f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutProvider.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutProvider.java
@@ -4,7 +4,6 @@
package org.chromium.chrome.browser.compositor.layouts;
-import android.graphics.Rect;
import android.graphics.RectF;
import org.chromium.chrome.browser.compositor.LayerTitleCache;
@@ -29,13 +28,7 @@ public interface LayoutProvider {
* @param rect RectF instance to be used to store the result and return. If null, it uses a new
* RectF instance.
*/
- void getViewportDp(RectF rect);
-
- /**
- * @param rect Rect instance to be used to store the result and return. If null, it uses a new
- * Rect instance.
- */
- void getViewportPixel(Rect rect);
+ void getViewportPixel(RectF rect);
/**
* @return The manager in charge of handling fullscreen changes.
@@ -54,7 +47,7 @@ public interface LayoutProvider {
* @return A {@link SceneLayer} that represents the content for this
* {@link Layout}.
*/
- SceneLayer getUpdatedActiveSceneLayer(Rect viewport, LayerTitleCache layerTitleCache,
+ SceneLayer getUpdatedActiveSceneLayer(RectF viewport, LayerTitleCache layerTitleCache,
TabContentManager tabContentManager, ResourceManager resourceManager,
ChromeFullscreenManager fullscreenManager);
}

Powered by Google App Engine
This is Rietveld 408576698